Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1 backport] Speed up and fix AppVeyor runs #4986

Merged
merged 3 commits into from
Jan 18, 2022

Conversation

kit-ty-kate
Copy link
Member

This fixes issues with the Cygwin run when the bootstrap ocaml compiler does not match the compiler being tested in appveyor.
It also brings faster CI runs.

Backports to 2.1 as mentioned in #4961 (comment)

appveyor_test.sh Outdated
@@ -2,6 +2,6 @@

COLD_OCAML="$(sed -ne 's/URL_ocaml = .*ocaml-.*ocaml-\(.*\)\.tar\.gz/ocaml.\1/p' src_ext/Makefile)"
# This is supposed to be able to select ocaml-system using the bootstrap compiler
opam init -y -a --compiler=$COLD_OCAML git+$OPAM_REPO#$OPAM_TEST_REPO_SHA
opam init -y -a --compiler=$COLD_OCAML git+https://github.com/ocaml/opam-repository#$OPAM_TEST_REPO_SHA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was correct - we need this line from master in appveyor.yml:

OPAM_REPO: https://github.com/ocaml/opam-repository.git

This test is becoming a bit dated, though, now that the testsuite
actually works.
@kit-ty-kate kit-ty-kate merged commit 1127a59 into ocaml:2.1 Jan 18, 2022
@kit-ty-kate kit-ty-kate deleted the windows-ci-fix branch January 18, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants