Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpamSystem.real_path: Remove the double chdir trick on OCaml >= 4.13.0 #4961

Merged
merged 5 commits into from
Jan 7, 2022
Merged

OpamSystem.real_path: Remove the double chdir trick on OCaml >= 4.13.0 #4961

merged 5 commits into from
Jan 7, 2022

Conversation

kit-ty-kate
Copy link
Member

Partially fixes #4793

@kit-ty-kate
Copy link
Member Author

Note for reviewers: I wasn’t able to move it to OpamCompat due to the let p = OpamCoreConfig.(!r.log_dir) in in OpamSystem.getchdir (cyclic dependency)

@dra27
Fix AppVeyor deployment target
bd522fb
@dra27
Select cold compiler for AppVeyor test
2821bbc 
This test is becoming a bit dated, though, now that the testsuite
actually works.
@dra27
Copy link
Member

dra27 commented Jan 7, 2022

Assuming it now passes, my two commits should go on 2.1 as well (it speeds up the build)

@kit-ty-kate kit-ty-kate merged commit a2c0e22 into ocaml:master Jan 7, 2022
@kit-ty-kate kit-ty-kate mentioned this pull request Jan 7, 2022
Merged
@rjbou rjbou added this to the 2.2.0~alpha milestone Jan 11, 2022
@rjbou rjbou mentioned this pull request May 25, 2022
Merged
@kit-ty-kate kit-ty-kate mentioned this pull request Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0~alpha
Development

Successfully merging this pull request may close these issues.

TODO: Get rid of the double Unix.chdir hack from the libraries
3 participants
@kit-ty-kate @dra27 @rjbou