+lwt.2.7.0, lwt_ssl.1.0.0, lwt_glib.1.0.0, lwt_react.1.0.0 #8196

aantron · 2017-01-03T19:59:34Z

Packages being factored out of Lwt, to be removed from the base lwt package in Lwt 3.0.0. See ocsigen/lwt#301.

I submitted these in a separate PR because I suspect they won't build in CI (due to constraints) until Lwt 2.7.0 is accepted.

EDIT: #8195.

camelus · 2017-01-03T20:01:39Z

❌ opam-lint errors `7a71502`

cowabloga.0.0.1 has errors:
- error 25: Missing field 'authors'
- error 35: Missing field 'homepage'
- warning 36: Missing field 'bug-reports'
cowabloga.0.0.2 has errors:
- error 25: Missing field 'authors'
- error 35: Missing field 'homepage'
- warning 36: Missing field 'bug-reports'
cowabloga.0.0.3 has errors:
- error 25: Missing field 'authors'
- error 35: Missing field 'homepage'
- warning 36: Missing field 'bug-reports'
cowabloga.0.0.4 has errors:
- error 25: Missing field 'authors'
- error 35: Missing field 'homepage'
- warning 36: Missing field 'bug-reports'
cowabloga.0.0.5 has errors:
- error 25: Missing field 'authors'
- error 35: Missing field 'homepage'
- warning 36: Missing field 'bug-reports'
cowabloga.0.0.6 has errors:
- error 25: Missing field 'authors'
- error 35: Missing field 'homepage'
- warning 36: Missing field 'bug-reports'
cowabloga.0.0.7 has errors:
- error 25: Missing field 'authors'
- error 35: Missing field 'homepage'
- warning 36: Missing field 'bug-reports'
cowabloga.0.0.8 has errors:
- error 25: Missing field 'authors'
- error 35: Missing field 'homepage'
- warning 36: Missing field 'bug-reports'
cowabloga.0.0.9 has errors:
- error 25: Missing field 'authors'
- error 35: Missing field 'homepage'
- warning 36: Missing field 'bug-reports'
release.1.0.0 has errors:
- error 25: Missing field 'authors'
- error 35: Missing field 'homepage'
- warning 36: Missing field 'bug-reports'
- warning 37: Missing field 'dev-repo'
release.1.0.1 has errors:
- error 25: Missing field 'authors'
- error 35: Missing field 'homepage'
- warning 36: Missing field 'bug-reports'
- warning 37: Missing field 'dev-repo'
release.1.0.3 has errors:
- error 25: Missing field 'authors'
- error 35: Missing field 'homepage'
- warning 36: Missing field 'bug-reports'
- warning 37: Missing field 'dev-repo'
release.1.0.4 has errors:
- error 25: Missing field 'authors'
- error 35: Missing field 'homepage'
- warning 36: Missing field 'bug-reports'
- warning 37: Missing field 'dev-repo'
release.1.1.0 has errors:
- error 25: Missing field 'authors'
- error 35: Missing field 'homepage'
- warning 36: Missing field 'bug-reports'
- warning 37: Missing field 'dev-repo'
release.1.1.1 has errors:
- error 25: Missing field 'authors'
- error 35: Missing field 'homepage'
- warning 36: Missing field 'bug-reports'
- warning 37: Missing field 'dev-repo'
usb.1.3.0 has errors:
- error 25: Missing field 'authors'
- warning 36: Missing field 'bug-reports'
- warning 37: Missing field 'dev-repo'
xe.0.6.0 has errors:
- error 25: Missing field 'authors'
- error 35: Missing field 'homepage'
- warning 36: Missing field 'bug-reports'
xe.0.6.2 has errors:
- error 25: Missing field 'authors'
- error 35: Missing field 'homepage'
- warning 36: Missing field 'bug-reports'
xe.0.6.3 has errors:
- error 25: Missing field 'authors'
- error 35: Missing field 'homepage'
- warning 36: Missing field 'bug-reports'
lwt.2.7.0 has some warnings:
- warning 41: Some packages are mentionned in package scripts of features, but there is no
  dependency or depopt toward them: "lwt_glib", "lwt_react", "lwt_ssl"
These packages passed lint tests: cowabloga.0.1.0, cowabloga.0.2.0, cowabloga.0.2.1, dog.0.1.0, dog.0.2.0, dog.0.2.1, lwt_glib.1.0.0, lwt_react.1.0.0, lwt_ssl.1.0.0, tlstunnel.0.1.0, tlstunnel.0.1.1, tlstunnel.0.1.2, tlstunnel.0.1.3, vpnkit.0.0.0

✅ Installability check (5949 → 5953)

new installable packages (4): lwt.2.7.0 lwt_glib.1.0.0 lwt_react.1.0.0 lwt_ssl.1.0.0

avsm · 2017-01-03T20:09:34Z

Any chance you could also merge in the lwt 2.7.0 PR into this branch please? It'll unblock CI.

aantron · 2017-01-03T20:19:28Z

Yes, I can do that. Do you mean after that PR is merged, or immediately?

avsm · 2017-01-03T20:24:19Z

Immediately would be good, as then the additional packages can be tested. There is also a new set of CI tests that can test reverse dependencies that will run.

aantron · 2017-01-03T20:46:17Z

I rebased over the Lwt base package branch, not including new upper bounds as waiting for the revdeps build to complete. Let me know what subsequent other squashes/rebases/merges/whatever you want, and also feel free to merge any way that is appropriate.

avsm · 2017-01-04T17:03:00Z

Thank you for all the upper bounds! One missing in the CI is release.1.1.1

# File "lib_test/master.ml", line 1:
# Error: Some fatal warnings were triggered (1 occurrences)
# Command exited with code 2.

All the others pass, yay!

aantron · 2017-01-04T17:07:52Z

Anil, I did add an upper bound on release.1.1.1. Indeed, from that log:

  - install lwt        2.6.0

It is failing because of deprecation warnings unrelated to Lwt.

aantron · 2017-01-04T17:10:19Z

Do you want me to constrain it anyway? I guess it requires OCaml < 4.03, but I can look in more detail.

aantron · 2017-01-04T17:11:44Z

Also, since the CI is working out fine, I suppose we should rename this PR and abandon the other one. Reasonable?

avsm · 2017-01-04T17:13:35Z

Constraining it to build would be great.

aantron · 2017-01-04T17:14:20Z

Yep already looking to be sure of the constraint, will add a commit shortly.

aantron · 2017-01-04T17:30:34Z

Ok, all releases of release have an offending combination of lines:

So I constrained them all to require < 4.03, except for release 1.0.2, which is already constrained to broken.

cc @andrenth

samoht · 2017-01-05T09:11:02Z

@avsm are you ok to merge this one? It seems that the remaining errors were already there.

Ideally we'd like to enable -warn-error for developer builds but disable -warn-error for tagged release builds. This patch disables -warn-error for both cases: it's not worth too much work on the current build and packaging system when we're likely to switch over to topkg soon. This allows vpnkit to build with lwt.2.7.0. Related to [ocaml/opam-repository#8195] Related to [ocaml/opam-repository#8196] Signed-off-by: David Scott <[email protected]>

avsm · 2017-01-06T11:23:12Z

Good to go! Thanks for all the hard work with the release, @aantron!

Ideally we would keep this as -warn-error for developer builds but disable for tagged release builds. This patch disables -warn-error for warning 3 for both cases: it's not worth too much work on the current build and packaging system when we're likely to switch over to topkg soon. This allows vpnkit to build with lwt.2.7.0. Related to [ocaml/opam-repository#8195] Related to [ocaml/opam-repository#8196] Signed-off-by: David Scott <[email protected]>

+lwt.2.7.0 - concurrency library

7f0fdd7

aantron force-pushed the lwt.2.7.0-extra branch from 09d2a50 to 587ff5d Compare January 3, 2017 20:44

aantron added 3 commits January 3, 2017 15:23

Constrain packages broken by Lwt 2.7.0 warnings

d366949

Add Camlp4 dependencies to usb and xe

755e39d

+lwt_ssl.1.0.0, lwt_glib.1.0.0, lwt_react.1.0.0

cfdc9b3

aantron force-pushed the lwt.2.7.0-extra branch from 587ff5d to cfdc9b3 Compare January 3, 2017 22:56

Package "release" requires OCaml < 4.03

7a71502

aantron changed the title ~~+lwt_ssl.1.0.0, lwt_glib.1.0.0, lwt_react.1.0.0~~ +lwt.2.7.0, lwt_ssl.1.0.0, lwt_glib.1.0.0, lwt_react.1.0.0 Jan 4, 2017

aantron mentioned this pull request Jan 4, 2017

+lwt.2.7.0 - concurrency library #8195

Closed

djs55 mentioned this pull request Jan 5, 2017

Disable -warn-error by default moby/vpnkit#168

Merged

avsm merged commit aac9ebc into ocaml:master Jan 6, 2017

aantron mentioned this pull request Jan 6, 2017

Release 2.7.0 on 3 January ocsigen/lwt#305

Closed

aantron mentioned this pull request Apr 11, 2017

+lwt.3.0.0 - concurrency library #8929

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

+lwt.2.7.0, lwt_ssl.1.0.0, lwt_glib.1.0.0, lwt_react.1.0.0 #8196

+lwt.2.7.0, lwt_ssl.1.0.0, lwt_glib.1.0.0, lwt_react.1.0.0 #8196

aantron commented Jan 3, 2017 •

edited

Loading

camelus commented Jan 3, 2017 •

edited

Loading

avsm commented Jan 3, 2017

aantron commented Jan 3, 2017

avsm commented Jan 3, 2017

aantron commented Jan 3, 2017

avsm commented Jan 4, 2017

aantron commented Jan 4, 2017

aantron commented Jan 4, 2017

aantron commented Jan 4, 2017

avsm commented Jan 4, 2017

aantron commented Jan 4, 2017

aantron commented Jan 4, 2017

samoht commented Jan 5, 2017

avsm commented Jan 6, 2017

+lwt.2.7.0, lwt_ssl.1.0.0, lwt_glib.1.0.0, lwt_react.1.0.0 #8196

+lwt.2.7.0, lwt_ssl.1.0.0, lwt_glib.1.0.0, lwt_react.1.0.0 #8196

Conversation

aantron commented Jan 3, 2017 • edited Loading

camelus commented Jan 3, 2017 • edited Loading

❌ opam-lint errors 7a71502

✅ Installability check (5949 → 5953)

avsm commented Jan 3, 2017

aantron commented Jan 3, 2017

avsm commented Jan 3, 2017

aantron commented Jan 3, 2017

avsm commented Jan 4, 2017

aantron commented Jan 4, 2017

aantron commented Jan 4, 2017

aantron commented Jan 4, 2017

avsm commented Jan 4, 2017

aantron commented Jan 4, 2017

aantron commented Jan 4, 2017

samoht commented Jan 5, 2017

avsm commented Jan 6, 2017

aantron commented Jan 3, 2017 •

edited

Loading

camelus commented Jan 3, 2017 •

edited

Loading

❌ opam-lint errors `7a71502`