Disable -warn-error by default #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps you could just remove warning 3 (deprecated feature) from the warning-as-error list? Most others are safe, I believe, and help keep the codebase clean by making warnings unmissable. |
Ideally we would keep this as -warn-error for developer builds but disable for tagged release builds. This patch disables -warn-error for warning 3 for both cases: it's not worth too much work on the current build and packaging system when we're likely to switch over to topkg soon. This allows vpnkit to build with lwt.2.7.0. Related to [ocaml/opam-repository#8195] Related to [ocaml/opam-repository#8196] Signed-off-by: David Scott <[email protected]>
djs55
force-pushed
the
disable-warn-error
branch
from
44d16ee
to
103fb78
Compare
|
@dsheets good idea, I'll do that. |
avsm
pushed a commit
to avsm/vpnkit
that referenced
this pull request
May 5, 2017
Use cstruct 2.2 to avoid memset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we'd like to enable -warn-error for developer builds but disable
-warn-error for tagged release builds. This patch disables -warn-error
for both cases: it's not worth too much work on the current build and
packaging system when we're likely to switch over to topkg soon.
This allows vpnkit to build with lwt.2.7.0.
Related to [ocaml/opam-repository#8195]
Related to [ocaml/opam-repository#8196]
Signed-off-by: David Scott [email protected]