Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] dune (15 packages) (3.16.1) #26816

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

maiste
Copy link
Contributor

@maiste maiste commented Oct 30, 2024

Fast, portable, and opinionated build system

CHANGES:

Fixed

CHANGES:

### Fixed

- Call the C++ compiler with `-std=c++11` when using OCaml >= 5.0
  (ocaml/dune#10962, @kit-ty-kate)
@shonfeder
Copy link
Contributor

AFAIK, this release adds a fix that is quite focused, and not expected to cause any subtle issues. The revdeps I've checked do not some seem to be new or failing due to relevant build issues.

I believe @maiste's examination has been found the same. So I this should be considered for merge. That said, this is my first time reviewing the publication of a central package, so I'd appreciate to deferring to @mseri or @raphael-proust on finally pulling the trigger. Anything else we should check here?

@mseri
Copy link
Member

mseri commented Nov 4, 2024

I also don't see new issues. Some pre-existing build failures can be fixed separately

@mseri
Copy link
Member

mseri commented Nov 4, 2024

Thanks for checking!

@mseri mseri merged commit 371a52f into ocaml:master Nov 4, 2024
2 of 3 checks passed
@maiste maiste deleted the release-dune-3.16.1 branch November 4, 2024 11:18
@shonfeder
Copy link
Contributor

When reviewing the PR, it became clear that having a record of the revdeps failures from the previous release would have helped save time. We would like to automate a solution for this time savings, but in the meantime, here is a record of the errors we can use to expedite review during the next release:

dune-3-16-1-revdeps-errors.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants