Call the C++ compiler with -std=c++11 when using OCaml >= 5.0 #10962
Conversation
kit-ty-kate
force-pushed
the
cpp-ocaml5
branch
from
6364e33
to
fcfab82
Compare
kit-ty-kate
force-pushed
the
cpp-ocaml5
branch
from
168e33e
to
15bd9ab
Compare
|
Could you please add a |
kit-ty-kate
force-pushed
the
cpp-ocaml5
branch
from
15bd9ab
to
05aa56a
Compare
done |
|
Can you also add a test that demonstrates the change in behavior? |
| @@ -3,10 +3,6 @@ | |||
|
|
|||
| open Import | |||
|
|
|||
| type phase = | |||
| | Compile | |||
| | Link | |||
There was a problem hiding this comment.
Is this refactoring essential to the fix?
There was a problem hiding this comment.
that type isn't used anywhere anymore and the removal of its use is essential to the fix (get_compile_flags is the only one that need the extra argument and places where get_link_flags is called do not have any way of getting that value, plus that would be wasteful)
There was a problem hiding this comment.
You could have also just modified the type to be:
type phase =
| Compile of Ocaml_config.t
| LinkThat would be a bit closer the old API and preserve some of the call sites.
It's not essential in this case as the refactoring is trivial, but in general I would like fixes and refactors to be as separate as possible.
kit-ty-kate
force-pushed
the
cpp-ocaml5
branch
from
8915cdc
to
dd245a5
Compare
done |
kit-ty-kate
force-pushed
the
cpp-ocaml5
branch
from
dd245a5
to
ac1a332
Compare
|
Are there any chance this could be merged in a patch release or something during this OCaml 5.3 alpha release cycle in the next couple of weeks? This would be really really appreciated |
Signed-off-by: Kate <[email protected]>
Signed-off-by: Rudi Grinberg <[email protected]>
Signed-off-by: Rudi Grinberg <[email protected]>
|
Thanks. I reverted the refactorings and also changed the check to use |
…10962) * Call the C++ compiler with -std=c++11 when using OCaml >= 5.0
…10962) * Call the C++ compiler with -std=c++11 when using OCaml >= 5.0 Signed-off-by: Etienne Marais <[email protected]>
* Call the C++ compiler with -std=c++11 when using OCaml >= 5.0 (#10962) * Call the C++ compiler with -std=c++11 when using OCaml >= 5.0 * Fix the compilation of OCaml 5 programs on Cygwin (#11009) strdup is not part of the C standard library but is part of POSIX. By default GCC and Clang both use the GNU variant of the C standard, so we are using strdup here to ensure users have access to it by default. If -std=c++11 is used instead of -std=gnu++11 this would fail to compile on non-POSIX platforms such as Cygwin. * test: backport missing test file --------- Signed-off-by: Etienne Marais <[email protected]> Signed-off-by: Kate <[email protected]> Co-authored-by: Kate <[email protected]> Co-authored-by: Kate <[email protected]>
CHANGES: ### Fixed - Call the C++ compiler with `-std=c++11` when using OCaml >= 5.0 (ocaml/dune#10962, @kit-ty-kate)
…10962) * Call the C++ compiler with -std=c++11 when using OCaml >= 5.0
Fixes #10886