Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctypes 0.21.1, ctypes-foreign 0.21.1 #24101

Merged
merged 17 commits into from
Jul 21, 2023
Merged

Conversation

yallop
Copy link
Member

@yallop yallop commented Jul 12, 2023

This release includes a switch to dune, which is a fairly major change (yallop/ocaml-ctypes#588), and may need some iteration before it's ready to merge.

@yallop yallop mentioned this pull request Jul 12, 2023
18 tasks
@emillon emillon force-pushed the ctypes-0.21.0 branch 2 times, most recently from b0036a9 to 952471e Compare July 17, 2023 09:38
The release tarball does not have version information. This adds it so
that the META file gets this information.
(this is used for example by the llvm build system)
Upstream is fixed in 0.1.4.
Upstream is fixed in 0.6.2.
Fixed upstream since 0.3.1.
@emillon
Copy link
Contributor

emillon commented Jul 17, 2023

I just rebased and included pointers to all the upstream fixes in the commit messages. I don't expect important failures in that run so let's see how it goes.

@emillon
Copy link
Contributor

emillon commented Jul 18, 2023

This looks all good now.

@yallop yallop marked this pull request as ready for review July 18, 2023 09:08
@avsm
Copy link
Member

avsm commented Jul 20, 2023

Would it be possible to include the patches in this PR in a release, and merge that instead? Where possible, we prefer to not carry upstream patches directly in the opam repository.

@yallop yallop closed this Jul 20, 2023
@yallop yallop deleted the ctypes-0.21.0 branch July 20, 2023 20:06
@yallop yallop reopened this Jul 20, 2023
@yallop yallop changed the title Add ctypes 0.21.0, ctypes-foreign 0.21.0 Add ctypes 0.21.1, ctypes-foreign 0.21.1 Jul 20, 2023
@yallop
Copy link
Member Author

yallop commented Jul 20, 2023

I've merged the patches into ctypes 0.21.1, and updated the PR to point to that release.

@yallop yallop restored the ctypes-0.21.0 branch July 20, 2023 20:07
@avsm avsm merged commit 9f1b40a into ocaml:master Jul 21, 2023
@avsm
Copy link
Member

avsm commented Jul 21, 2023

Thanks @yallop and @emillon for getting this over the line to be released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants