ctypes: fix compat with 0.21.0 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ctypes < 0.21.0, the ctypes and ctypes.foreign libraries were installed in the same directory, so depending on one would make the other one visible. ctypes 0.21.0 installs them in different directories so this makes it an error. udev.ml actually uses ctypes.foreign so it should depend on it.
18 tasks
|
That looks good, thanks! |
|
No, thanks. I'm just cleaning up revdeps as we're releasing the new version. But if you prefer, I can also just add the patch to the existing opam release (or make a |
|
Adding the patch to the current opam release sounds good, yes, thanks! |
emillon
added a commit
to yallop/opam-repository
that referenced
this pull request
Jul 17, 2023
Upstream fix: Armael/ocaml-libudev#1
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
Upstream fix: Armael/ocaml-libudev#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ctypes < 0.21.0, the ctypes and ctypes.foreign libraries were installed in the same directory, so depending on one would make the other one visible.
ctypes 0.21.0 installs them in different directories so this makes it an error.
udev.ml actually uses ctypes.foreign so it should depend on it.