Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mirage-runtime 4.*: avoid ppxlib >= 0.29.0 #23312

Merged
merged 2 commits into from
Feb 14, 2023
Merged

mirage-runtime 4.*: avoid ppxlib >= 0.29.0 #23312

merged 2 commits into from
Feb 14, 2023

Commits on Feb 14, 2023

  1. mirage-runtime 4.*: avoid ppxlib >= 0.29.0 

    The underlying issue is opam-monorepo:

==> Using lockfile /src/mirage.opam.locked
Successfully pulled 117/117 repositories
�[01;2m�[01;35m2023-02-14 09:31.51 ---> saved as "ae35e626e84e036206eb1c0f2b774e22b35519257a4891cdc9e7aea5da8ec6b8"�[0m

�[01;34m/src/: (env DUNE_CACHE enabled)�[0m

�[01;34m/src/: (env DUNE_CACHE_TRANSPORT direct)�[0m

�[01;34m/src/: (run (cache (dune-build-cache (target /home/opam/.cache/dune)))
            (network host)
            (shell "opam exec -- make build"))�[0m
dune build
Error: Too many opam files for package "ppx_sexp_conv":
- duniverse/ppx_sexp_conv/ppx_sexp_conv.opam
- duniverse/ppxlib/bench/vendored/ppx_sexp_conv.v0.15.1/ppx_sexp_conv.opam
make: *** [Makefile:80: build] Error 1
"/bin/bash" "-c" "opam exec -- make build" failed with exit status 2

2023-02-14 09:31.52: Job failed: Failed: Build failed
    @hannesm
    hannesm committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    31fe929 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @kit-ty-kate
    kit-ty-kate authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    65e542d View commit details
    Browse the repository at this point in the history