mirage-runtime 4.*: avoid ppxlib >= 0.29.0 #23312
Conversation
The underlying issue is opam-monorepo:
==> Using lockfile /src/mirage.opam.locked
Successfully pulled 117/117 repositories
�[01;2m�[01;35m2023-02-14 09:31.51 ---> saved as "ae35e626e84e036206eb1c0f2b774e22b35519257a4891cdc9e7aea5da8ec6b8"�[0m
�[01;34m/src/: (env DUNE_CACHE enabled)�[0m
�[01;34m/src/: (env DUNE_CACHE_TRANSPORT direct)�[0m
�[01;34m/src/: (run (cache (dune-build-cache (target /home/opam/.cache/dune)))
(network host)
(shell "opam exec -- make build"))�[0m
dune build
Error: Too many opam files for package "ppx_sexp_conv":
- duniverse/ppx_sexp_conv/ppx_sexp_conv.opam
- duniverse/ppxlib/bench/vendored/ppx_sexp_conv.v0.15.1/ppx_sexp_conv.opam
make: *** [Makefile:80: build] Error 1
"/bin/bash" "-c" "opam exec -- make build" failed with exit status 2
2023-02-14 09:31.52: Job failed: Failed: Build failed
|
I'm trying to get a hold of someone in the ppxlib team to see if this can be fixed in a potential 0.29.1 (in which case only |
|
@kit-ty-kate thanks. also, @TheLortex mentioned that ocaml/dune#7058 may be a fine solution once implemented and released. Since the ppxlib release didn't even bother to add an entry about the vendoring in the changelog, I felt the best is to mark this conflict and potentially in the future relax the constraint. |
There was a problem hiding this comment.
ocaml-ppx/ppxlib#386 just got merged and 0.29.1 should get released soon.
|
Thanks |
|
Thanks a lot for the super quick fix on this, @kit-ty-kate! FWIW, I've also just added an entry to the 0.29.0 release notes pointing out this problem (@hannesm). The reason why we hadn't added it yet is simply that we missed the chain of consequences, starting with adding an isolated PD: ocaml/dune#7058 seems like it would be nice! |
|
Also, if something like this happens again in the future, please feel free to open an issue at |
The underlying issue is opam-monorepo:
==> Using lockfile /src/mirage.opam.locked
Successfully pulled 117/117 repositories
�[01;2m�[01;35m2023-02-14 09:31.51 ---> saved as "ae35e626e84e036206eb1c0f2b774e22b35519257a4891cdc9e7aea5da8ec6b8"�[0m
�[01;34m/src/: (env DUNE_CACHE enabled)�[0m
�[01;34m/src/: (env DUNE_CACHE_TRANSPORT direct)�[0m
�[01;34m/src/: (run (cache (dune-build-cache (target /home/opam/.cache/dune)))
(network host)
(shell "opam exec -- make build"))�[0m
dune build
Error: Too many opam files for package "ppx_sexp_conv":
"/bin/bash" "-c" "opam exec -- make build" failed with exit status 2
2023-02-14 09:31.52: Job failed: Failed: Build failed