Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rpclib #12441

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Add rpclib #12441

merged 1 commit into from
Aug 6, 2018

Conversation

samoht
Copy link
Member

@samoht samoht commented Aug 6, 2018

@samoht samoht mentioned this pull request Aug 6, 2018
Merged
@camelus
Copy link
Contributor

camelus commented Aug 6, 2018

✅ All lint checks passed 2dbde2c
  • These packages passed lint tests: rpclib.5.9.0
✅ Installability check (9189 → 9190)
  • new installable packages (1): rpclib.5.9.0

@samoht samoht merged commit bd13d78 into ocaml:master Aug 6, 2018
@samoht samoht deleted the rpclib branch August 6, 2018 13:51
@mseri
Copy link
Member

mseri commented Aug 6, 2018

@jonludlam @gaborigloi we should announce this (now that also the lwt, ashnc and ppx parts are released) in th discourse forum. Esoecially given the improvements i the documentation (readme) added by gabor

@gaborigloi
Copy link
Contributor

@mseri Should we wait for mirage/ocaml-rpc#117 to be merged and the interface to be stabilized first? That way we'd avoid breaking changes after the announcement.
I think we should merge that PR and test it, and possibly remove the exn stuff that we don't need, and then we can have another release.

@mseri
Copy link
Member

mseri commented Aug 7, 2018

@gaborigloi ok, makes sense to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samoht @camelus @mseri @gaborigloi