Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally use rpclib if it's available #26

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

samoht
Copy link
Contributor

@samoht samoht commented Aug 6, 2018

No description provided.

@samoht
Copy link
Contributor Author

samoht commented Aug 6, 2018

This probably needs ocaml/opam-repository#12441 to be merged first

@samoht
Copy link
Contributor Author

samoht commented Aug 6, 2018

And also ocaml/opam-repository#12443

Copy link
Contributor

@gaborigloi gaborigloi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

We do have an rpc compatibility package, but that hasn't been added to the main opam repo, and is less fine-grained than the new packages.

@lindig
Copy link
Contributor

lindig commented Aug 7, 2018

The change needs to go into https://github.com/xapi-project/xs-opam, too - packages/xs/rrd.1.3.0/opam

@robhoes
Copy link
Member

robhoes commented Aug 14, 2018

Any reason not to merge this right now?

@edwintorok
Copy link
Contributor

The build on xs-opam has passed, so we can merge it.

@edwintorok edwintorok merged commit d518b29 into xapi-project:master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants