Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a reproduction case for #8158 #8165

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

emillon
Copy link
Collaborator

@emillon emillon commented Jul 10, 2023

No description provided.

Copy link
Collaborator

@Alizter Alizter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you will update this when the fix is merged.

Copy link
Collaborator

@Alizter Alizter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you will update this when the fix is merged.

@rgrinberg
Copy link
Member

We have some existing tests for similar functionality written by @gridbugs that don't rely on ppxlib. I'd suggest to just follow along what he has.

@rgrinberg rgrinberg requested a review from gridbugs July 10, 2023 15:33
@emillon
Copy link
Collaborator Author

emillon commented Jul 10, 2023

@rgrinberg I just did that, let me know what you think.

@emillon emillon merged commit cf710dc into ocaml:main Jul 10, 2023
@emillon emillon deleted the test-8158 branch July 10, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants