fix(staged_pps): expand path relative to root #8159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't have to be in this PR, but do we not have any tests touching this? It would be good to have some for the future at least. |
|
We have tests but only with libs at the root. This one is on me; I checked that |
rgrinberg
approved these changes
Jul 10, 2023
rgrinberg
approved these changes
Jul 10, 2023
|
Done in #8165. |
|
Rebased on top of the failing test; this shows the fix. |
Alizter
approved these changes
Jul 10, 2023
Fixes ocaml#8158 This is an error introduced in ocaml#8109, not part of a release. Signed-off-by: Etienne Millon <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8158
This is an error introduced in #8109, not part of a release.