Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug causing all executables to be considered as optional #3163

Merged
8 commits merged into from Feb 19, 2020
Merged

Fix a bug causing all executables to be considered as optional #3163

8 commits merged into from Feb 19, 2020

Commits on Feb 19, 2020

  1. Modernise optional-executable test 

    Signed-off-by: Jeremie Dimino <[email protected]>
    @jeremiedimino
    jeremiedimino committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    978e00c View commit details
    Browse the repository at this point in the history

  2. Add a reproduction case for non-optional executable problem 

    Signed-off-by: Jeremie Dimino <[email protected]>
    @jeremiedimino
    jeremiedimino committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    58d40c3 View commit details
    Browse the repository at this point in the history

  3. Fix non-optional executable problem 

    All executables where considered as optional. Change the code so that
only ones marked as optional are indeed optional.

Signed-off-by: Jeremie Dimino <[email protected]>
    @jeremiedimino
    jeremiedimino committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    0eb7710 View commit details
    Browse the repository at this point in the history

  4. Modernise the optional test 

    Signed-off-by: Jeremie Dimino <[email protected]>
    @jeremiedimino
    jeremiedimino committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    7e50fe1 View commit details
    Browse the repository at this point in the history

  5. Add a similar test for libraries 

    Signed-off-by: Jeremie Dimino <[email protected]>
    @jeremiedimino
    jeremiedimino committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    8d0d9aa View commit details
    Browse the repository at this point in the history

  6. Make the library test match the executable one 

    For good measure

Signed-off-by: Jeremie Dimino <[email protected]>
    @jeremiedimino
    jeremiedimino committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    107ea52 View commit details
    Browse the repository at this point in the history

  7. Update changes 

    Signed-off-by: Jeremie Dimino <[email protected]>
    @jeremiedimino
    jeremiedimino committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    5b2c902 View commit details
    Browse the repository at this point in the history

  8. fmt 

    Signed-off-by: Jeremie Dimino <[email protected]>
    @jeremiedimino
    jeremiedimino committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    3b18d8c View commit details
    Browse the repository at this point in the history