Fix a bug causing all executables to be considered as optional #3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremie Dimino <[email protected]>
Signed-off-by: Jeremie Dimino <[email protected]>
All executables where considered as optional. Change the code so that only ones marked as optional are indeed optional. Signed-off-by: Jeremie Dimino <[email protected]>
Signed-off-by: Jeremie Dimino <[email protected]>
Signed-off-by: Jeremie Dimino <[email protected]>
For good measure Signed-off-by: Jeremie Dimino <[email protected]>
Signed-off-by: Jeremie Dimino <[email protected]>
Signed-off-by: Jeremie Dimino <[email protected]>
ghost
mentioned this pull request
rgrinberg
approved these changes
Feb 19, 2020
ghost
merged commit
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Feb 20, 2020
…lugin, dune-private-libs and dune-glob (2.3.1)
CHANGES:
- Fix versioning of artifact variables (eg %{cmxa:...}), which were introduced
in 2.0, not 1.11. (ocaml/dune#3149, @nojb)
- Fix a bug introduced in 2.3.0 where dune insists on using `fswatch` on linux
(even when `inotifywait` is available). (ocaml/dune#3162, @aalekseyev)
- Fix a bug causing all executables to be considered as optional (ocaml/dune#3163, @diml)
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Feb 22, 2020
…lugin, dune-private-libs and dune-glob (2.3.1)
CHANGES:
- Fix versioning of artifact variables (eg %{cmxa:...}), which were introduced
in 2.0, not 1.11. (ocaml/dune#3149, @nojb)
- Fix a bug introduced in 2.3.0 where dune insists on using `fswatch` on linux
(even when `inotifywait` is available). (ocaml/dune#3162, @aalekseyev)
- Fix a bug causing all executables to be considered as optional (ocaml/dune#3163, @diml)
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Feb 23, 2020
…lugin, dune-private-libs and dune-glob (2.3.1)
CHANGES:
- Fix versioning of artifact variables (eg %{cmxa:...}), which were introduced
in 2.0, not 1.11. (ocaml/dune#3149, @nojb)
- Fix a bug introduced in 2.3.0 where dune insists on using `fswatch` on linux
(even when `inotifywait` is available). (ocaml/dune#3162, @aalekseyev)
- Fix a bug causing all executables to be considered as optional (ocaml/dune#3163, @diml)
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Feb 24, 2020
…lugin, dune-private-libs and dune-glob (2.3.1)
CHANGES:
- Fix versioning of artifact variables (eg %{cmxa:...}), which were introduced
in 2.0, not 1.11. (ocaml/dune#3149, @nojb)
- Fix a bug introduced in 2.3.0 where dune insists on using `fswatch` on linux
(even when `inotifywait` is available). (ocaml/dune#3162, @aalekseyev)
- Fix a bug causing all executables to be considered as optional (ocaml/dune#3163, @diml)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now all executables are considered as optional, which is clearly wrong. This patch adds a regression test and fixes the issue. Now only executables marked with
(optional)are indeed considered as optional.Libraries are not affected, but for good measure I added a similar check to inspect the
.optionalfield.