Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the beginning of a new build more explicit in watch mode #2542

Merged
1 commit merged into from Aug 12, 2019
Merged

Make the beginning of a new build more explicit in watch mode #2542

1 commit merged into from Aug 12, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 12, 2019

Print the following on every new build in watch mode:

                                          
********** NEW BUILD **********

@rgrinberg
Copy link
Member

Rather than this change, what do you think about making the new setting for watch the default? I think it's much better to just see the current status rather than what came before it.

Also, perhaps we should make sure that this addresses #1970 as well.

@ghost
Copy link
Author

ghost commented Aug 12, 2019

I haven't tried the new setting much, but last time I tried it I found something annoying: if you have multiple errors, they are all cleared as soon as a new build starts, which is annoying.

In any case, this change seems good to me even if we change the default. What do you think?

@rgrinberg
Copy link
Member

Sure, sounds good to me. What about some colors btw? :)

@bobzhang would be it be possible to integrate this with vs code?

@ghost
Copy link
Author

ghost commented Aug 12, 2019

It's bold and in bright green :)

@ghost ghost merged commit f4eba24 into ocaml:master Aug 12, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants