-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better integration with vscode #1970
Conversation
bobzhang
commented
Mar 22, 2019
- For watch mode, vscode needs a begin pattern, end pattern pair
- For error exits, it would be nice to have an indicator
Signed-off-by: Hongbo <[email protected]>
Are these configurable in vscode? The error markers in this PR are kind of shouty and not in the normal dune style. |
Yes, it is possible to create a tasks.json file to specify the patterns for beginning and end. In my current setup it looks like this (works only because I call dune from a makefile).
|
The above isn't all that great either. |
Can we detect if we are being run by vscode? |
Would it do any harm to have a clear delimiter in general? Currently the dune output is verbose, without a decent integration with editor, you have to search pages to find the location.. |
The capital letter are a bit loud, so if it only works in vscode, it seems better to use them only when running under vscode. Could you try passing |
see #1733 |
? |