Remove all the shady Option.value_exn in lib.ml #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
remove-db-value-exn
branch
from
d1d874d
to
ac1904c
Compare
TheLortex
suggested changes
Apr 29, 2019
TheLortex
suggested changes
Apr 29, 2019
|
@rgrinberg I tested with your fork and I no longer have the internal error. |
rgrinberg
force-pushed
the
remove-db-value-exn
branch
from
561047e
to
f34b23d
Compare
|
@TheLortex I've amended the fix to consider dbs recursively |
TheLortex
approved these changes
Apr 30, 2019
Should fix ocaml#2085 Signed-off-by: Rudi Grinberg <[email protected]>
Signed-off-by: Rudi Grinberg <[email protected]>
Signed-off-by: Rudi Grinberg <[email protected]>
rgrinberg
force-pushed
the
remove-db-value-exn
branch
from
f34b23d
to
bffe5ba
Compare
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
May 2, 2019
CHANGES: - Put back library variants in development mode. We discovered a serious unexpected issue and we might need to adjust the design of this feature before we are ready to commit to a final version. Users will need to write `(using library_variants 0.1)` in their `dune-project` file if they want to use it before the design is finalized. (ocaml/dune#2116, @diml) - Forbid to attach a variant to a library that implements a virtual library outside the current project (ocaml/dune#2104, @rgrinberg) - Fix a bug where `dune install` would install man pages to incorrect paths when compared to `opam-installer`. For example dune now installs `(foo.1 as man1/foo.1)` correctly and previously that was installed to `man1/man1/foo.1`. (ocaml/dune#2105, @aalekseyev) - Do not fail when a findlib directory doesn't exist (ocaml/dune#2101, fix ocaml/dune#2099, @diml) - [coq] Rename `(coqlib ...)` to `(coq.theory ...)`, support for `coqlib` will be dropped in the 1.0 version of the Coq language (ocaml/dune#2055, @ejgallego) - Fix crash when calculating library dependency closure (ocaml/dune#2090, fixes ocaml/dune#2085, @rgrinberg)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can we get @TheLortex as a reviewer on this?
@vsiles could you confirm this fixes your bug? #2085