Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coq] Rename (coqlib ...) to (coq.theory ...) #2055

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

ejgallego
Copy link
Collaborator

Support for the first form will be dropped in the 1.0 version of the
Coq language.

Copy link
Member

@rgrinberg rgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would also mention in the error message when the old name would be removed.

Support for the first form will be dropped in the 1.0 version of the
Coq language.

Signed-off-by: Emilio Jesus Gallego Arias <[email protected]>
@ejgallego
Copy link
Collaborator Author

Looks good. I would also mention in the error message when the old name would be removed.

Done, thanks.

@ejgallego ejgallego merged commit 1b65a3d into ocaml:master Apr 12, 2019
@ejgallego ejgallego deleted the coq+rename branch April 12, 2019 18:46
rgrinberg added a commit to rgrinberg/opam-repository that referenced this pull request May 2, 2019
CHANGES:

- Put back library variants in development mode. We discovered a
  serious unexpected issue and we might need to adjust the design of
  this feature before we are ready to commit to a final version. Users
  will need to write `(using library_variants 0.1)` in their
  `dune-project` file if they want to use it before the design is
  finalized. (ocaml/dune#2116, @diml)

- Forbid to attach a variant to a library that implements a virtual
  library outside the current project (ocaml/dune#2104, @rgrinberg)

- Fix a bug where `dune install` would install man pages to incorrect
  paths when compared to `opam-installer`. For example dune now
  installs `(foo.1 as man1/foo.1)` correctly and previously that was
  installed to `man1/man1/foo.1`. (ocaml/dune#2105, @aalekseyev)

- Do not fail when a findlib directory doesn't exist (ocaml/dune#2101, fix ocaml/dune#2099, @diml)

- [coq] Rename `(coqlib ...)` to `(coq.theory ...)`, support for
  `coqlib` will be dropped in the 1.0 version of the Coq language
  (ocaml/dune#2055, @ejgallego)

- Fix crash when calculating library dependency closure (ocaml/dune#2090, fixes ocaml/dune#2085,
  @rgrinberg)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants