Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OCaml 4.13 #250

Merged
merged 6 commits into from
Aug 24, 2021
Merged

Add support for OCaml 4.13 #250

merged 6 commits into from
Aug 24, 2021

Conversation

kit-ty-kate
Copy link
Contributor

@jberdine
Copy link
Contributor

jberdine commented Jun 4, 2021

I don't know if it's useful, but I pinned this PR in a 4.13-alpha1 switch and the build fails:

dune build --auto-promote @install
      ocamlc traverse/.ppxlib_traverse.objs/byte/ppxlib_traverse.{cmi,cmo,cmt} (exit 2)
(cd _build/default && /Users/jjb/.opam/sledge_test/bin/ocamlc.opt -w @[email protected]@30..39@[email protected]@[email protected] -strict-sequence -strict-formats -short-paths -keep-locs -safe-string -g -bin-annot -I traverse/.ppxlib_traverse.objs/byte -I /Users/jjb/.opam/sledge_test/lib/stdlib-shims -I ast/.ppxlib_ast.objs/byte -I src/.ppxlib.objs/byte -I stdppx/.stdppx.objs/byte -I traverse_builtins/.ppxlib_traverse_builtins.objs/byte -no-alias-deps -opaque -o traverse/.ppxlib_traverse.objs/byte/ppxlib_traverse.cmo -c -impl traverse/ppxlib_traverse.pp.ml)
>> Fatal error: OCaml and preprocessor have incompatible versions
Fatal error: exception Misc.Fatal_error
make: *** [Makefile:5: default] Error 1

This is after pinning omp to #114.

@kit-ty-kate
Copy link
Contributor Author

@jberdine thanks a lot, the magic number got bumped the day before yesterday and I hadn't seen it. It should be fixed now.

@jberdine
Copy link
Contributor

jberdine commented Jun 4, 2021

Thanks, that worked and let me get somewhat further. There are still a number of ppx_* packages that don't build with 4.13 so I haven't done any real testing so far.

@kit-ty-kate
Copy link
Contributor Author

Feel free to use https://github.com/kit-ty-kate/opam-alpha-repository/, it contains some of the fixes you might need.

@pitag-ha
Copy link
Member

pitag-ha commented Jun 8, 2021

Thanks @kit-ty-kate! Would you mind adding a changelog entry to point out that this commit makes ppxlib compatible with 4.13? And could you also sign the commit?

@pitag-ha
Copy link
Member

pitag-ha commented Jun 8, 2021

There are still a number of ppx_* packages that don't build

@jberdine, are you referring to the packages listed here? Or are there more?

@pitag-ha pitag-ha added the no changelog Use this label to disable the changelog check github action label Jun 21, 2021
@pitag-ha
Copy link
Member

Would you mind adding a changelog entry

Never mind this anymore, since the support will already be added in 0.22.2 and we have a changelog entry for it there. I've added the no changelog label.

And could you also sign the commit?

That would still be great, though!

@pitag-ha
Copy link
Member

Just in case someone comes across this PR: this PR is currently not very active, since we've also backported it to 0.22 and released it there. Concretely, ppxlib.0.22.2 is 4.13 compatible.

@pitag-ha
Copy link
Member

@kit-ty-kate, could you sign the commits?

@kit-ty-kate
Copy link
Contributor Author

@pitag-ha Done

Copy link
Member

@pitag-ha pitag-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kit-ty-kate!

@pitag-ha pitag-ha merged commit c21d1b0 into ocaml-ppx:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Use this label to disable the changelog check github action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants