-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OCaml 4.13 #250
Conversation
I don't know if it's useful, but I pinned this PR in a 4.13-alpha1 switch and the build fails:
This is after pinning omp to #114. |
@jberdine thanks a lot, the magic number got bumped the day before yesterday and I hadn't seen it. It should be fixed now. |
Thanks, that worked and let me get somewhat further. There are still a number of ppx_* packages that don't build with 4.13 so I haven't done any real testing so far. |
Feel free to use https://github.com/kit-ty-kate/opam-alpha-repository/, it contains some of the fixes you might need. |
Thanks @kit-ty-kate! Would you mind adding a changelog entry to point out that this commit makes ppxlib compatible with 4.13? And could you also sign the commit? |
Never mind this anymore, since the support will already be added in 0.22.2 and we have a changelog entry for it there. I've added the
That would still be great, though! |
Just in case someone comes across this PR: this PR is currently not very active, since we've also backported it to |
@kit-ty-kate, could you sign the commits? |
Signed-off-by: Kate <[email protected]>
Signed-off-by: Kate <[email protected]>
Signed-off-by: Kate <[email protected]>
Signed-off-by: Kate <[email protected]>
Signed-off-by: Kate <[email protected]>
@pitag-ha Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kit-ty-kate!
Ports ocaml-ppx/ocaml-migrate-parsetree#114