Add support for OCaml 4.13 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
added a commit
to kit-ty-kate/ppxlib
that referenced
this pull request
May 31, 2021
kit-ty-kate
added a commit
to kit-ty-kate/ppxlib
that referenced
this pull request
May 31, 2021
|
Merging #115 first should fix CI |
19 tasks
…nerated migrate_* files Co-authored-by: Sonja Heinze <[email protected]>
Co-authored-by: Sonja Heinze <[email protected]>
Co-authored-by: Sonja Heinze <[email protected]>
|
CI is green. |
The functions `copy_location` and `copy_Longident_t` have already been simplified. Those two together with `copy_location_stack` are the only functions whose signature doesn't rely on AST types.
pitag-ha
approved these changes
Jun 18, 2021
There was a problem hiding this comment.
Thanks @kit-ty-kate! The commits I've just pushed are just a coherency and a "book-keeping" commit.
pitag-ha
added a commit
to pitag-ha/opam-repository
that referenced
this pull request
Jun 21, 2021
CHANGES: - Add support for 4.13 (ocaml-ppx/ocaml-migrate-parsetree#114, @kit-ty-kate)
kit-ty-kate
added a commit
to kit-ty-kate/ppxlib
that referenced
this pull request
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joint work with @pitag-ha
I detailed the commit between the pure generated ones using the tools and commands provided, the manual modifications to make it work and the extra add-ons with cinaps