Refactor Plugin + add missed typing #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added a simple Expo app demo to test the plugin within the repository. I also had the opportunity to test the refactoring done in #34, but it appears that it is not functioning in a real-world application. The plugin is not adding a badge to the app icon.
This is a return to the old behavior until we find the best option to fix it.
For people want to test here is how
pnpm install
.pnpm run prebuild-demo
.demo/ios/demo/Images.xcassets/AppIcon.appiconset/[email protected]
anddemo/android/app/src/main/res
.withDangerMod
implementation, replace the function insideapp.plugin.ts
with an async function and test again.#31