Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Plugin + add missed typing #35

Merged
merged 14 commits into from
Oct 28, 2024
Merged

Refactor Plugin + add missed typing #35

merged 14 commits into from
Oct 28, 2024

Conversation

yjose
Copy link
Member

@yjose yjose commented Oct 22, 2024

This PR added a simple Expo app demo to test the plugin within the repository. I also had the opportunity to test the refactoring done in #34, but it appears that it is not functioning in a real-world application. The plugin is not adding a badge to the app icon.

This is a return to the old behavior until we find the best option to fix it.

For people want to test here is how

  1. Clone the branch.
  2. Run pnpm install.
  3. Execute pnpm run prebuild-demo.
  4. Check the native folder inside the demo for icons with badges at demo/ios/demo/Images.xcassets/AppIcon.appiconset/[email protected] and demo/android/app/src/main/res.
  5. If you want to try the withDangerMod implementation, replace the function inside app.plugin.ts with an async function and test again.

#31

@yjose
Copy link
Member Author

yjose commented Oct 22, 2024

@janwiebe-jump 👀

@yjose yjose requested review from 0x1337ak and SihamBen October 22, 2024 15:32
@yjose yjose merged commit b65abcb into master Oct 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant