-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build fail on expo eas build #31
Comments
@yjose Do you have any experience with this problem? |
@bhyoo99 I am a bit confused because we are not using |
Yes, I try without plugin, it works. I'll test it in more ways and leave an additional message THX |
Same issue locally with expo 50
|
I'm also seeing the same fairly frequently - sometimes it works, and sometimes it doesn't:
I currently suspect that sometimes the wrong file is being read in as an icon - that's what produces the error. Will dig in to see if there's anywhere this is possible... |
@Harjot1Singh Ok, Maybe I know what is causing the issue. Normally, the function we are calling to add the badge is async, but the problem is that the config plugin don't support running async function and we mainly running it without Apparently, this is working for most cases but may cause this issue to appear sometimes. The solution is to look at how we can run the function using await and ensure that the new images are generated before updating the @SihamBen can you help on that whenever you have some free time 🙏 |
Sounds about right, @yjose, thansk for getting back! I can think of 2 solutions:
|
Quickly jumping here after some investigations. my android build was failing on I encountered the same messages as @Harjot1Singh
from my understanding the error message suggests Jimp encountered an issue parsing a buffer, possibly due to a missing or corrupt image file in your project. I somehow solved the issue adding this on android: {
++ icon: "./assets/images/icon.png",
adaptiveIcon: {
foregroundImage: "./assets/images/adaptive-icon.png",
backgroundColor: "#ffffff"
}, I am not 100% convinced it is related but maybe it could help someone 😅 |
Same issue for eas Android, any updates? |
same issue need updates |
eas: "version": ">= 12.3.0", |
@Harjot1Singh, we tried using the mod to generate the icon with a badge, but it seems that Expo generates the native icons before running the plugin. I am not sure about your second approach, to be honest. How can you do that? For anyone who wants to play with it, here is the PR. |
@yjose just updated package, all works, thanks a lot!!! |
@maksim-romanov @yjose Thank you! Have a nice day :) |
I'm still encountering this issue with Expo 52 and the latest version of this package. The problem occurs on both iOS and Android builds. |
in eas prebuild [Android, iOS]
draft solution
using v0.0.13 it works!fail in ios too
The text was updated successfully, but these errors were encountered: