-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
obs-filters: Add preprocessor guard to libSpeexDSP method
#4730
Merged
jp9000
merged 1 commit into
obsproject:master
from
tommyvct:noise-suppress-filter_ifdef_fix
Oct 24, 2021
Merged
obs-filters: Add preprocessor guard to libSpeexDSP method
#4730
jp9000
merged 1 commit into
obsproject:master
from
tommyvct:noise-suppress-filter_ifdef_fix
Oct 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be a different way to fix the same thing #4601 is intended to fix. |
tommyvct
force-pushed
the
noise-suppress-filter_ifdef_fix
branch
from
May 29, 2021 04:54
014794c
to
c6d3418
Compare
tommyvct
changed the title
obs-filters: added preprocessor guard to
obs-filters: add preprocessor guard to May 29, 2021
method
method
`method` should be used under the same condition as they were defined. That is when both `LIBRNNOISE_ENABLED` and `LIBSPEEXDSP_ENABLED` are defined.
tommyvct
force-pushed
the
noise-suppress-filter_ifdef_fix
branch
from
July 3, 2021 21:38
c6d3418
to
a6325ba
Compare
tommyvct
changed the title
obs-filters: add preprocessor guard to
obs-filters: Add preprocessor guard to Jul 3, 2021
method
method
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Jul 3, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to non-ARM platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Jul 3, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to non-ARM platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Jul 3, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Jul 4, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Jul 26, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Jul 29, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Jul 29, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Aug 4, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Aug 5, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Aug 5, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Aug 14, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Aug 15, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Aug 17, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Aug 17, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Aug 26, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Sep 6, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
changed the title
obs-filters: Add preprocessor guard to
obs-filters: Add preprocessor guard to libSpeexDSP Sep 17, 2021
method
method
jpark37
pushed a commit
to jpark37/obs-studio
that referenced
this pull request
Sep 18, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
jpark37
pushed a commit
to jpark37/obs-studio
that referenced
this pull request
Sep 18, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Sep 18, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Oct 5, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Oct 5, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 Windows ARM64: Initial support CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 obs-qsv11: Add ENABLE_QSV11 option obs-qsv11: Add ENABLE_QSV11 option
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Oct 5, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 Windows ARM64: Initial support CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 obs-qsv11: Add ENABLE_QSV11 option obs-qsv11: Add ENABLE_QSV11 option
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Oct 5, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 Windows ARM64: Initial support CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 obs-qsv11: Add ENABLE_QSV11 option obs-qsv11: Add ENABLE_QSV11 option
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Oct 19, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 Windows ARM64: Initial support CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 obs-qsv11: Add ENABLE_QSV11 option obs-qsv11: Add ENABLE_QSV11 option
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Oct 25, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 Windows ARM64: Initial support CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 obs-qsv11: Add ENABLE_QSV11 option obs-qsv11: Add ENABLE_QSV11 option
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Oct 26, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 Windows ARM64: Initial support CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 obs-qsv11: Add ENABLE_QSV11 option obs-qsv11: Add ENABLE_QSV11 option
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Dec 11, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 Windows ARM64: Initial support CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 obs-qsv11: Add ENABLE_QSV11 option obs-qsv11: Add ENABLE_QSV11 option
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Dec 11, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 Windows ARM64: Initial support CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 obs-qsv11: Add ENABLE_QSV11 option obs-qsv11: Add ENABLE_QSV11 option
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Dec 13, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 Windows ARM64: Initial support CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 obs-qsv11: Add ENABLE_QSV11 option obs-qsv11: Add ENABLE_QSV11 option UI: Remove Qt Windows Extras for Qt 6 and later
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Dec 13, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 Windows ARM64: Initial support CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 obs-qsv11: Add ENABLE_QSV11 option obs-qsv11: Add ENABLE_QSV11 option UI: Remove Qt Windows Extras for Qt 6 and later
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Dec 13, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 Windows ARM64: Initial support CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 obs-qsv11: Add ENABLE_QSV11 option obs-qsv11: Add ENABLE_QSV11 option UI: Remove Qt Windows Extras for Qt 6 and later UI: Remove Qt Windows Extras for Qt 6 and later Co-Authored-By: Matt Gajownik <[email protected]>
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Dec 13, 2021
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 Windows ARM64: Initial support CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 obs-qsv11: Add ENABLE_QSV11 option obs-qsv11: Add ENABLE_QSV11 option UI: Remove Qt Windows Extras for Qt 6 and later UI: Remove Qt Windows Extras for Qt 6 and later UI: Remove Qt Windows Extras for Qt 6 and later Co-Authored-By: Matt Gajownik <[email protected]>
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Jan 1, 2022
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 Windows ARM64: Initial support CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 obs-qsv11: Add ENABLE_QSV11 option obs-qsv11: Add ENABLE_QSV11 option UI: Remove Qt Windows Extras for Qt 6 and later UI: Remove Qt Windows Extras for Qt 6 and later UI: Remove Qt Windows Extras for Qt 6 and later Co-Authored-By: Matt Gajownik <[email protected]>
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Jan 4, 2022
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 Windows ARM64: Initial support CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 obs-qsv11: Add ENABLE_QSV11 option obs-qsv11: Add ENABLE_QSV11 option UI: Remove Qt Windows Extras for Qt 6 and later UI: Remove Qt Windows Extras for Qt 6 and later UI: Remove Qt Windows Extras for Qt 6 and later Co-Authored-By: Matt Gajownik <[email protected]>
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Jan 4, 2022
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 Windows ARM64: Initial support CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 obs-qsv11: Add ENABLE_QSV11 option obs-qsv11: Add ENABLE_QSV11 option UI: Remove Qt Windows Extras for Qt 6 and later UI: Remove Qt Windows Extras for Qt 6 and later UI: Remove Qt Windows Extras for Qt 6 and later Co-Authored-By: Matt Gajownik <[email protected]>
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Jan 5, 2022
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 Windows ARM64: Initial support CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 obs-qsv11: Add ENABLE_QSV11 option obs-qsv11: Add ENABLE_QSV11 option UI: Remove Qt Windows Extras for Qt 6 and later UI: Remove Qt Windows Extras for Qt 6 and later UI: Remove Qt Windows Extras for Qt 6 and later Co-Authored-By: Matt Gajownik <[email protected]>
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Jan 8, 2022
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 Windows ARM64: Initial support CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 obs-qsv11: Add ENABLE_QSV11 option obs-qsv11: Add ENABLE_QSV11 option UI: Remove Qt Windows Extras for Qt 6 and later UI: Remove Qt Windows Extras for Qt 6 and later UI: Remove Qt Windows Extras for Qt 6 and later Co-Authored-By: Matt Gajownik <[email protected]>
tommyvct
added a commit
to tommyvct/obs-studio
that referenced
this pull request
Jan 8, 2022
CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 Windows ARM64: Initial support CI: Add GitHub Action Windows ARM64 CI This mega commit also includes the changes from the following PR: cmake: Add DISABLE_QSV11 option to disable QSV encoder obsproject#4748 libobs: Restrict emmintrin.h to x86(_64) platform obsproject#4746 Resolve potential symbol clash on MSVC obsproject#4743 obs-filters: Add preprocessor guard to method obsproject#4730 obs-qsv11: Add ENABLE_QSV11 option obs-qsv11: Add ENABLE_QSV11 option UI: Remove Qt Windows Extras for Qt 6 and later UI: Remove Qt Windows Extras for Qt 6 and later UI: Remove Qt Windows Extras for Qt 6 and later Co-Authored-By: Matt Gajownik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
method
should be used under the same condition as they were defined. That is when bothLIBRNNOISE_ENABLED
andLIBSPEEXDSP_ENABLED
are defined.Description
method
should be used under the same condition as they were defined. That is when bothLIBRNNOISE_ENABLED
andLIBSPEEXDSP_ENABLED
are defined.Motivation and Context
Trying to compile for Windows ARM64 using MSVC toolchain.
The compiler is complaining
method
is not defined.https://discord.com/channels/348973006581923840/374636084883095554/844802474547085323
How Has This Been Tested?
I added the guard and it's compiling!
Types of changes
Preprocessor definition guard change.
Checklist: