Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obs-filters: Don't require libSpeexDSP to compile #4601

Closed
wants to merge 1 commit into from
Closed

obs-filters: Don't require libSpeexDSP to compile #4601

wants to merge 1 commit into from

Conversation

Xaymar
Copy link
Contributor

@Xaymar Xaymar commented Apr 27, 2021

Description

Removes the requirement of libSpeexDSP and libRNNoise for building obs-filters with just NVAFX

Motivation and Context

Got annoyed that i needed additional libraries to successfully build obs-studio when all i want is nvafx.

How Has This Been Tested?

OBS Studio compiles without libSpeexDSP.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Code Cleanup Non-breaking change which makes code smaller or more readable label Apr 27, 2021
@Xaymar
obs-filters: Compile without libSpeexDSP and/or libRNNNoise
272a7d2 
Allows compiling obs-filters with just NVAFX, requiring neither of the other two libraries.
@Xaymar Xaymar mentioned this pull request May 20, 2021
Merged
6 tasks
@tommyvct tommyvct mentioned this pull request May 29, 2021
Draft
19 tasks
@Xaymar
Copy link
Contributor Author

Xaymar commented Aug 5, 2021

Closing as requested.

@Xaymar Xaymar closed this Aug 5, 2021
@tommyvct
Copy link
Contributor

What happened, why is this closed?

@Xaymar Xaymar deleted the patch-3 branch September 12, 2021 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Cleanup Non-breaking change which makes code smaller or more readable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xaymar @tommyvct @WizardCM