mac-virtualcam: Fix remaining global namespaces #3785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives the MachServer a unique name which was forgotten in a previous commit
WizardCM
added
Bug Fix
|
Yep that's what I would've done to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gives the MachServer of the mac-virtualcam a unique name which was forgotten in a previous commit (#3758)
Motivation and Context
@PatTheMav noticed he forgot to change this in his PR (johnboiles/obs-mac-virtualcam#242 (comment)), I hope this is what he meant.
He described all other details in his PR #3758, which is probably a way better explanation than what I could give.
How Has This Been Tested?
Built locally on my machine (macOS 11.0.1, Intel), and tested that the virtual camera still works.
Types of changes
Checklist: