mac-virtualcam: Fix global namespace issues in DAL plugin #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gxalpha Feel free to download the artifact once it's done and check the built-in plugin. As you have SIP disabled the lack of signing shouldn't be an issue then. |
|
Works for me, can't test if its compatible with EOS Webcam Utility though since I dont have it. 👍 |
|
❤️ this is awesome. Thanks @PatTheMav |
johnboiles
approved these changes
Nov 23, 2020
johnboiles
reviewed
Nov 23, 2020
| <string>PlugInMain</string> | ||
| </dict> | ||
| <key>CFPlugInTypes</key> | ||
| <dict> | ||
| <key>30010C1C-93BF-11D8-8B5B-000A95AF9C6A</key> | ||
| <array> | ||
| <string>35FDFF29-BFCF-4644-AB77-B759DE932ABE</string> | ||
| <string>7E950B8C-5E49-4B9E-B7D0-B3608A08E8F6</string> |
There was a problem hiding this comment.
Good idea to switch this
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes global namespaces issues in the DAL plugin that will arise when another DAL plugin based on the same example code is installed on the system.
Motivation and Context
ObjectiveC does symbol lookups at runtime, which means that two plugins can be loaded with identical symbol names. This leads to undefined behaviour as it is not defined which class/method will be used.
The issue was mentioned in johnboiles/obs-mac-virtualcam#215 before and has been shown to interfere with the EOS Webcam Utility for macOS (which also didn't namespace its functions uniquely) johnboiles/obs-mac-virtualcam#232 (comment).
How Has This Been Tested?
Virtualcam tested locally with the plugin-version installed to check if there are still ambiguous symbols.
Types of changes
Checklist: