obs-webrtc: Do not use curl_easy_nextheader #10786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sean-Der
force-pushed
the
curl-no-header-api
branch
from
70c353b to
2ec44db
Compare
tt2468
requested changes
Jun 7, 2024
|
Other than those nitpicks, the code looks good to me. It builds for me now on Ubuntu 22.04. Unfortunately, I am unable to test it at the moment due to |
API not available in Ubuntu 22.04 which ships 7.81 this API was first available in 7.83
Sean-Der
force-pushed
the
curl-no-header-api
branch
from
2ec44db to
6864099
Compare
6 tasks
DDRBoxman
approved these changes
Jun 7, 2024
RytoEX
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
API not available in Ubuntu 22.04 which ships 7.81 this API was first available in 7.83
Motivation and Context
Fixes build on Ubuntu 22.04
How Has This Been Tested?
Tested against WHIP server with TURN
Tested against Broadcast Box
Tested against Twitch
Types of changes
Checklist: