-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
obs-webrtc: Add Link Header support #10524
Conversation
I just tested this against OBS Studio and it seems to be working flawlessly. |
654f876
to
4fe9a05
Compare
@tt2468 Could I get a review of this one now please? |
6edce9e
to
b986f28
Compare
I have created a test application that confirms this is working. You can get it here https://github.com/Sean-Der/whip-turn-test The only thing you need to change is the IP address of the host you are running the server on here OBS without this patch running against this server behaves like this. It shows WHIP connected and starting pushing media.
Without this change the server prints the following. OBS doesn't have TURN support so is unable to connect
Some users today who are using WHIP will see OBS unable to connect and have no idea why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, mostly around adding comments so this is easier to make sense of later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Posed a question, but feedback is not blocking.
92ca232
to
8192535
Compare
WHIP/WHEP allows ICE Servers to be specified via Link Headers[0] [0] https://www.ietf.org/archive/id/draft-ietf-wish-whip-13.html#name-stun-turn-server-configurat Co-authored-by: Takeru Ohta <[email protected]>
Thank you so much @DDRBoxman @RytoEX I really appreciate the reviews :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm noticing that this PR appears to be un-compilable on Ubuntu 22.04 due to the usage of |
I will work on fixing this now @tt2468 |
Fixed with #10786 |
Description
WHIP/WHEP allows ICE Servers to be specified via Link Headers
Motivation and Context
Some WebRTC deployments are behind a NAT. Companies/developers place their TURN server on the edge, and use that to access the TURN servers.
I have had 3 companies reach out to me about this, so implemented it.
How Has This Been Tested?
Ran broadcast-box and only listened on
127.0.0.1
and confirmed that traffic could be routed through pion/turnTypes of changes
Checklist: