fix: entity exporter should use logs_endpoint, instead of endpoint #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use endpoint, OTel agent will append it with "/logs" as the real URL. Not what we want.
|
The following chart updates are necessary: |
xueweiz
force-pushed
the
xuewei/fixUrl
branch
from
89d646e to
3c11bc0
Compare
| @@ -15,7 +15,7 @@ otlphttp/observe/base: | |||
|
|
|||
| {{- define "config.exporters.otlphttp.observe.entity" -}} | |||
| otlphttp/observe/entity: | |||
| endpoint: "{{ .Values.observe.collectionEndpoint.value | toString | trimSuffix "/" }}/v1/kubernetes/v1/entity" | |||
| logs_endpoint: "{{ .Values.observe.collectionEndpoint.value | toString | trimSuffix "/" }}/v1/kubernetes/v1/entity" | |||
There was a problem hiding this comment.
Do we also need metrics_endpoint/traces_endpoint?
There was a problem hiding this comment.
(we don't support traces yet
for metrics, we use a dedicated prometheus endpoint + prometheus remotewrite exporter for it, and it has been running healthily for a while :)
The prom remote write exporter does NOT do these "url suffixing" stuff :D
obs-gh-mattcotter
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use endpoint, OTel agent will append it with "/logs" as the real URL. Not what we want.