Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waffle stroke #2204

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

waffle stroke #2204

wants to merge 2 commits into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Oct 19, 2024 •
edited
Loading

closes #2186

before after
before after

(to apply after #2203)

@Fil Fil requested a review from mbostock October 19, 2024 16:13
Fil
Fil commented Oct 19, 2024
View reviewed changes
test/output/waffleHref.svg Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no visual difference here

Fil
Fil commented Oct 19, 2024
View reviewed changes
test/output/waffleStroke.svg
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test and the other ones below have a small visible difference, but for the best

Fil
Fil commented Oct 19, 2024
View reviewed changes
test/output/waffleStrokeWidth.svg
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would be unchanged

Fil
Fil commented Oct 19, 2024
View reviewed changes
test/output/waffleStrokeWidthConst.svg
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test is the one exhibiting the bug (see description)

Base automatically changed from fil/waffle-href to main October 19, 2024 17:14
mbostock
mbostock reviewed Oct 19, 2024
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thing I noticed is that these waffles have invisible slivers that extend the full width of the band. Related to #2132 I guess. Need more time to work on this but we probably want to simplify the polygon we’re using to render the waffle cells.

image

@Fil
Copy link
Contributor Author

Fil commented Oct 19, 2024

Yes, it explains the gradient we see at the top of the "before" image in the description. It would be nice to clean this up too.

(Related: #2132)

@mbostock mbostock mentioned this pull request Oct 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Waffle pattern does not account for strokeWidth
2 participants
@Fil @mbostock