Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waffle pattern does not account for strokeWidth #2186

Open
mootari opened this issue Oct 4, 2024 · 1 comment · May be fixed by #2204
Open

Waffle pattern does not account for strokeWidth #2186

mootari opened this issue Oct 4, 2024 · 1 comment · May be fixed by #2204
Assignees
Labels
bug Something isn’t working

Comments

@mootari
Copy link
Member

mootari commented Oct 4, 2024

When a Waffle mark has a stroke applied, the pattern size does not account for the added stroke width which causes neighboring strokes to bleed through at the edges.

Example:

Plot.waffleX([6], {gap: 6, stroke: "black", strokeWidth: 5}).plot({height: 200})
@mootari mootari added the bug Something isn’t working label Oct 4, 2024
@Fil
Copy link
Contributor

Fil commented Oct 19, 2024

Confirmed, will fix. Note that this only happens when the stroke is a constant, so a stopgap measure could be to write stroke: () => "black".

@Fil Fil self-assigned this Oct 19, 2024
@Fil Fil linked a pull request Oct 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants