Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support configuring pod and container security context #32

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

jsirianni
Copy link
Member

In an effort to support OpenShift, we need to make pod and container securityContext configurable by the user. This PR moves the hardcoded securityContext options to two new sections in the values file.

podSecurityContext:
  fsGroup: 65534

containerSecurityContext:
  runAsNonRoot: true
  runAsUser: 65534
  readOnlyRootFilesystem: true
  capabilities:
    drop: ["ALL"]

This change behaves identically by default, but allows user to modify securityContext.

Does not fully resolve OpenShift support, but this PR does address one of the first steps identified by a user here #16

@jsirianni jsirianni changed the title support configuring pod and container security context feat: Support configuring pod and container security context Jun 26, 2023
@jsirianni jsirianni marked this pull request as ready for review June 26, 2023 13:25
@jsirianni jsirianni requested a review from a team as a code owner June 26, 2023 13:25
@jsirianni jsirianni requested review from jmwilliams89 and cpheps and removed request for jmwilliams89 June 26, 2023 13:25
@jsirianni jsirianni merged commit f09003c into main Jun 26, 2023
@jsirianni jsirianni deleted the securitycontext branch June 26, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants