Support OpenShift 3.x and 4.x

[jsirianni]

OpenShift will likely work without issue, however, some things are different. For example, OS 3.11 does not support startup probe.

[PaulEvans8669]

Hello @jsirianni ,

Me and my team are currently working on deploying this chart on openshift 4.X. We are facing issues where the runAsUser and fsGroup values of the bindplane.yaml template are hardcoded to 66534 :

https://github.com/observIQ/bindplane-op-helm/blob/main/charts/bindplane/templates/bindplane.yaml#L33
https://github.com/observIQ/bindplane-op-helm/blob/main/charts/bindplane/templates/bindplane.yaml#L355

This is a major issue for us as this prevents us from deploying the ressource. OpenShift requires these values to be in a specific range (rootless uids). Making those securityContext fully customizable via the values.yaml, would fix this issue.
(Examples here : https://github.com/grafana/helm-charts/blob/main/charts/grafana/templates/_pod.tpl#L9-L12, https://github.com/prometheus-community/helm-charts/blob/main/charts/prometheus/templates/deploy.yaml#L62-L65 )

This would be a first step for us, as we would be able to deploy the chart, and get pods running for further possible debugging.

[jsirianni]

Hi @PaulEvans8669, thank you for the suggestion. I can probably get a release out today that supports modifying securityContext.

[jsirianni]

Hi @PaulEvans8669, I still need to have my team review this, but if you would like to check this PR I would love to have your feedback #32

[PaulEvans8669]

Hello @jsirianni , this looks very good from my point of view.

I'm really looking forward to see this get merged :)
Thank you!

[jsirianni]

@PaulEvans8669 we have merged and released, you can find the release here https://github.com/observIQ/bindplane-op-helm/releases/tag/bindplane-0.0.33.

Please let us know if you need anything else 👍