Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link open new tab fix & minor table styling fixes #811

Merged
merged 3 commits into from
Dec 7, 2024
Merged

fix: link open new tab fix & minor table styling fixes #811

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82d7c0b
fix: minor fixes, new tab for anthropic link & table styling
ivyjeong13 Dec 6, 2024
a43cf7b
Update table.tsx
ivyjeong13 Dec 6, 2024
c0796cf
Update table.tsx
ivyjeong13 Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ui/admin/app/components/model-providers/ModelProviderConfigure.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,11 @@ export function ModelProviderConfigureContent({
{modelProvider.id === CommonModelProviderIds.ANTHROPIC && (
<DialogDescription className="px-4">
Note: Anthropic does not have an embeddings model and{" "}
<Link to="https://docs.anthropic.com/en/docs/build-with-claude/embeddings">
<Link
target="_blank"
rel="noreferrer"
to="https://docs.anthropic.com/en/docs/build-with-claude/embeddings"
>
recommends
</Link>{" "}
Voyage AI.
Expand Down
12 changes: 7 additions & 5 deletions ui/admin/app/components/model-providers/ModelProviderModels.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,13 @@ export function ModelProvidersModels({ modelProvider }: ModelsConfigureProps) {
</DialogHeader>
<ScrollArea className="h-[50vh]">
{!isLoading && (
<DataTable
columns={getColumns()}
data={models}
sort={[{ id: "name", desc: false }]}
/>
<div className="px-6">
<DataTable
columns={getColumns()}
data={models}
sort={[{ id: "name", desc: false }]}
/>
</div>
)}
</ScrollArea>
</DialogContent>
Expand Down
2 changes: 1 addition & 1 deletion ui/admin/app/components/ui/table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const TableRow = React.forwardRef<
<tr
ref={ref}
className={cn(
"border-b transition-colors hover:bg-muted/30 data-[state=selected]:bg-muted",
"transition-colors hover:bg-muted/30 data-[state=selected]:bg-muted",
className
)}
{...props}
Expand Down