Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: link open new tab fix & minor table styling fixes #811

Merged
merged 3 commits into from
Dec 7, 2024
Merged

fix: link open new tab fix & minor table styling fixes #811

merged 3 commits into from
Dec 7, 2024

Conversation

ivyjeong13
Copy link
Contributor

  • adds padding to align model provider header with start of table row
  • opens new tab for anthropic link
  • removes border-b from table rows

ryanhopperlowe
ryanhopperlowe approved these changes Dec 7, 2024
View reviewed changes
Copy link
Contributor

@ryanhopperlowe ryanhopperlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JFYI this is going to remove borders from every table app-wide. Just want to make sure you checked that they still look decent :)

@ivyjeong13
Copy link
Contributor Author

JFYI this is going to remove borders from every table app-wide. Just want to make sure you checked that they still look decent :)

After input from Craig, reverted for now!

@ivyjeong13 ivyjeong13 merged commit 8e29d4e into obot-platform:main Dec 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanhopperlowe ryanhopperlowe ryanhopperlowe approved these changes

@cjellick cjellick cjellick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivyjeong13 @cjellick @ryanhopperlowe