Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lints: Breaking changes in macros #946

Closed
8 tasks done
Tracked by #5
obi1kenobi opened this issue Sep 26, 2024 · 1 comment · Fixed by #1050
Closed
8 tasks done
Tracked by #5

New lints: Breaking changes in macros #946

obi1kenobi opened this issue Sep 26, 2024 · 1 comment · Fixed by #1050
Labels
A-lint Area: new or existing lint E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@obi1kenobi
Copy link
Owner

obi1kenobi commented Sep 26, 2024

There are several ways to cause a breaking change by changing macro item definitions that we can lint for today:

Relevant docs we can use as references in the lints:

The lints here will be similar to existing "item missing" lints (e.g. enum missing, enum variant missing), with one important difference: macros are always at the top level of the crate that defined them. They don't have importable paths, so our matching doesn't need the importable_path edge like for other items and can instead simply rely on the macro's own name.

Make sure to check out our contributing guide, and take a look at what prior lints' merged PRs looked like so you know what to expect. It's easier than you think!

@obi1kenobi obi1kenobi added A-lint Area: new or existing lint E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue. labels Sep 26, 2024
@miikka
Copy link
Contributor

miikka commented Oct 10, 2024

I'll give a go at implementing "removing a declarative macro that used to exist".

obi1kenobi added a commit that referenced this issue Dec 7, 2024
Addresses a checkbox in #946

---------

Co-authored-by: Predrag Gruevski <[email protected]>
obi1kenobi pushed a commit that referenced this issue Dec 7, 2024
obi1kenobi pushed a commit that referenced this issue Dec 7, 2024
obi1kenobi pushed a commit that referenced this issue Dec 7, 2024
obi1kenobi pushed a commit that referenced this issue Dec 8, 2024
Addresses checkbox in #946 . Distinguish between macros that are hidden
vs just not exported.
obi1kenobi added a commit that referenced this issue Dec 8, 2024
Addresses checkbox in
#946

---------

Co-authored-by: Predrag Gruevski <[email protected]>
obi1kenobi added a commit that referenced this issue Dec 16, 2024
obi1kenobi added a commit that referenced this issue Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lint Area: new or existing lint E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants