-
-
Notifications
You must be signed in to change notification settings - Fork 78
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add lint attribute_proc_macro_missing (#1026)
Addresses a checkbox in #946
- Loading branch information
Showing
7 changed files
with
105 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
SemverQuery( | ||
id: "attribute_proc_macro_missing", | ||
human_readable_name: "attribute proc macro removed", | ||
description: "An attribute proc macro that previously existed is no longer available.", | ||
required_update: Major, | ||
lint_level: Deny, | ||
reference_link: Some("https://doc.rust-lang.org/reference/procedural-macros.html#attribute-macros"), | ||
query: r#" | ||
{ | ||
CrateDiff { | ||
baseline { | ||
item { | ||
... on AttributeProcMacro { | ||
visibility_limit @filter(op: "=", value: ["$public"]) | ||
name @output @tag | ||
span_: span @optional { | ||
filename @output | ||
begin_line @output | ||
} | ||
} | ||
} | ||
} | ||
current @fold @transform(op: "count") @filter(op: "=", value: ["$zero"]) { | ||
item { | ||
... on AttributeProcMacro { | ||
visibility_limit @filter(op: "=", value: ["$public"]) | ||
name @filter(op: "=", value: ["%name"]) | ||
} | ||
} | ||
} | ||
} | ||
}"#, | ||
arguments: { | ||
"public": "public", | ||
"zero": 0, | ||
}, | ||
error_message: "A previously available attribute macro has been removed, breaking code that uses attribute syntax on annotated items.", | ||
per_result_error_template: Some("macro #[{{name}}] in {{span_filename}}:{{span_begin_line}}"), | ||
witness: None, | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
[package] | ||
publish = false | ||
name = "attribute_proc_macro_missing" | ||
version = "0.1.0" | ||
edition = "2021" | ||
|
||
[lib] | ||
proc-macro = true | ||
|
||
[dependencies] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
use proc_macro::TokenStream; | ||
|
||
// Keep other macro types to verify specific detection | ||
#[proc_macro] | ||
pub fn sql(_item: TokenStream) -> TokenStream { | ||
TokenStream::new() | ||
} | ||
|
||
#[proc_macro_derive(MyDerive)] | ||
pub fn my_derive(_item: TokenStream) -> TokenStream { | ||
TokenStream::new() | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
[package] | ||
publish = false | ||
name = "attribute_proc_macro_missing" | ||
version = "0.1.0" | ||
edition = "2021" | ||
|
||
[lib] | ||
proc-macro = true | ||
|
||
[dependencies] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
use proc_macro::TokenStream; | ||
|
||
#[proc_macro_attribute] | ||
pub fn logging(_attr: TokenStream, item: TokenStream) -> TokenStream { | ||
item | ||
} | ||
|
||
// Keep this to verify we don't trigger on function-like macros | ||
#[proc_macro] | ||
pub fn sql(_item: TokenStream) -> TokenStream { | ||
TokenStream::new() | ||
} | ||
|
||
// Keep this to verify we don't trigger on derive macros | ||
#[proc_macro_derive(MyDerive)] | ||
pub fn my_derive(_item: TokenStream) -> TokenStream { | ||
TokenStream::new() | ||
} |
14 changes: 14 additions & 0 deletions
14
test_outputs/query_execution/attribute_proc_macro_missing.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
--- | ||
source: src/query.rs | ||
expression: "&query_execution_results" | ||
snapshot_kind: text | ||
--- | ||
{ | ||
"./test_crates/attribute_proc_macro_missing/": [ | ||
{ | ||
"name": String("logging"), | ||
"span_begin_line": Uint64(4), | ||
"span_filename": String("src/lib.rs"), | ||
}, | ||
], | ||
} |