-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade CI to node v18 #1306
Upgrade CI to node v18 #1306
Conversation
Deploying with Cloudflare Pages
|
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov Report
@@ Coverage Diff @@
## master #1306 +/- ##
=======================================
Coverage 84.61% 84.61%
=======================================
Files 142 142
Lines 3601 3602 +1
Branches 660 660
=======================================
+ Hits 3047 3048 +1
Misses 554 554
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why there were issues with deps and extension in the second PR. It looks like everything is fine here.
Fixes error when building: "@parcel/optimizer-terser: You must provide the URL of lib/mappings.wasm by"
The new Intl.dateFormat functions sometimes use a "Narrow No-Break Space" instead of a normal space in the dates, before the AM/PM suffices. The behavior seems to be somewhat non-deterministic, which makes testing difficult. This change simply normalizes the output to always use a simple space.
Alternative to #1143
Difference: only upgraded parcel and cypress transitive dependencies (by reinstalling parcel and cypress), instead of all transitive dependencies (by recreating yarn.lock)
CI succeeded with these changes: