Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CI to node v18 #1306

Merged
merged 6 commits into from
Mar 3, 2023
Merged

Upgrade CI to node v18 #1306

merged 6 commits into from
Mar 3, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Mar 3, 2023

Alternative to #1143
Difference: only upgraded parcel and cypress transitive dependencies (by reinstalling parcel and cypress), instead of all transitive dependencies (by recreating yarn.lock)

CI succeeded with these changes:

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 3, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ba450df
Status: ✅  Deploy successful!
Preview URL: https://c3fdfafc.oasis-wallet.pages.dev
Branch Preview URL: https://lw-node18.oasis-wallet.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.11s
✅ EDITORCONFIG editorconfig-checker 5 0 0.02s
✅ JSON eslint-plugin-jsonc 1 0 0 0.71s
✅ JSON jsonlint 1 0 0.2s
✅ JSON npm-package-json-lint yes no 0.44s
✅ JSON prettier 1 0 0 0.41s
✅ JSON v8r 1 0 5.11s
✅ REPOSITORY checkov yes no 11.89s
✅ REPOSITORY git_diff yes no 0.0s
✅ TSX eslint 1 0 0 3.54s
✅ YAML prettier 2 0 0 0.54s
✅ YAML v8r 2 0 2.24s
✅ YAML yamllint 2 0 0.24s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #1306 (c3587c4) into master (8106429) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c3587c4 differs from pull request most recent head ba450df. Consider uploading reports for the commit ba450df to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1306   +/-   ##
=======================================
  Coverage   84.61%   84.61%           
=======================================
  Files         142      142           
  Lines        3601     3602    +1     
  Branches      660      660           
=======================================
+ Hits         3047     3048    +1     
  Misses        554      554           
Flag Coverage Δ
cypress 51.33% <66.66%> (+0.01%) ⬆️
jest 80.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/DateFormatter/index.tsx 100.00% <100.00%> (ø)

Copy link
Contributor

@buberdds buberdds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why there were issues with deps and extension in the second PR. It looks like everything is fine here.

@lukaw3d lukaw3d requested a review from csillag March 3, 2023 17:08
@lukaw3d lukaw3d changed the title Node18 Upgrade to node v18 Mar 3, 2023
lukaw3d and others added 6 commits March 3, 2023 19:28
Fixes error when building:
"@parcel/optimizer-terser: You must provide the URL of lib/mappings.wasm by"
The new Intl.dateFormat functions sometimes use a
"Narrow No-Break Space" instead of a normal space
in the dates, before the AM/PM suffices.

The behavior seems to be somewhat non-deterministic, which
makes testing difficult.

This change simply normalizes the output to always use a simple space.
@lukaw3d lukaw3d changed the title Upgrade to node v18 Upgrade CI to node v18 Mar 3, 2023
@lukaw3d lukaw3d merged commit ef76686 into master Mar 3, 2023
@lukaw3d lukaw3d deleted the lw/node18 branch March 3, 2023 18:39
@buberdds buberdds mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants