-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for node v18 #1143
Update for node v18 #1143
Conversation
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports |
Please note that the failing tests are because the CI is still configured to use node v14, and our package json demands v18. |
As an aside, one could probably do a tighter update; ie. instead of removing the whole yarn.lock file, update only a few dependencies selectively... but it's a PITA to figure out exactly which ones, and eventually we need to upgrade all of them anyway. |
Can you bump node version in GH actions? |
There is something wrong with the newer react dependencies... |
7439e7c
to
e812396
Compare
That has been solved, but now I have an issue whereas |
0546571
to
27d7d3c
Compare
Now only the Cypress tests are dead... |
This change has been created my removing yarn.lock, and then running yarn again to resolve all the dependencies. Lots of versions change.
The new Intl.dateFormat functions sometimes use a "Narrow No-Break Space" instead of a normal space in the dates, before the AM/PM suffices. The behavior seems to be somewhat non-deterministic, which makes testing difficult. This change simply normalizes the output to always use a simple space.
27d7d3c
to
d9263ff
Compare
Done via #1306 |
In the current version of the code
This is an upstream bug that has been fixed since we locked our dependency versions.
The situation can be resolved by removing
yarn.lock
and thus updating all our dependencies.This results in many changes.
One of the changes is that date formatting now uses a different kind of space; I updated the tests for that.
After this changes node v18 works OK (compilation, tests, everything), but node v14 and v16 no longer works.
(Actually, the code does work with node v16, but the tests don't, and I didn't feel like debugging it, since node v18 is already the current LTS release...)
So of we do this, everyone working on the wallet must upgrade to node v18.