Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-sdk/core: do not enforce batch gas limit for CheckTx #290

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jul 19, 2021

With oasisprotocol/oasis-core#4131 oasis-core will be scheduling CheckTx batches. The runtime scheduler cannot enforce batch-limits for non-checked transactions, therefore the runtime should not enforce these either.

Other batch limits (emitted messages, batch size) are already not enforced for check-tx batches.

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #290 (abc99aa) into main (6dad5ed) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   70.70%   70.78%   +0.07%     
==========================================
  Files          57       57              
  Lines        3455     3464       +9     
==========================================
+ Hits         2443     2452       +9     
  Misses        992      992              
  Partials       20       20              
Impacted Files Coverage Δ
runtime-sdk/src/modules/core/mod.rs 80.58% <100.00%> (+0.38%) ⬆️
runtime-sdk/src/modules/core/test.rs 95.17% <100.00%> (+0.17%) ⬆️
runtime-sdk/src/testing/mock.rs 90.32% <100.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dad5ed...abc99aa. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/feature/batchlimit-checktx branch 2 times, most recently from 528b040 to b695384 Compare July 20, 2021 15:43
@ptrus ptrus force-pushed the ptrus/feature/batchlimit-checktx branch from b695384 to abc99aa Compare July 20, 2021 16:11
@ptrus ptrus enabled auto-merge July 20, 2021 16:17
@ptrus ptrus merged commit 9464aa3 into main Jul 20, 2021
@ptrus ptrus deleted the ptrus/feature/batchlimit-checktx branch July 20, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants