go/worker/executor: batch CheckTx transactions #4131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/feature/checktx-queue
branch
5 times, most recently
from
d721f15 to
f8c2679
Compare
Codecov Report
@@ Coverage Diff @@
## master #4131 +/- ##
==========================================
- Coverage 69.24% 68.81% -0.43%
==========================================
Files 410 411 +1
Lines 47250 47363 +113
==========================================
- Hits 32716 32593 -123
- Misses 10508 10760 +252
+ Partials 4026 4010 -16
Continue to review full report at Codecov.
|
ptrus
force-pushed
the
ptrus/feature/checktx-queue
branch
2 times, most recently
from
7594f3f to
1f5d55a
Compare
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
kostko
reviewed
Jul 15, 2021
| @@ -44,5 +44,6 @@ func (ub *unresolvedBatch) resolve(ctx context.Context, sb storage.Backend) (tra | |||
| if err != nil { | |||
| return nil, fmt.Errorf("failed to fetch inputs from storage: %w", err) | |||
| } | |||
| ub.batch = batch | |||
go/worker/compute/executor/committee/orderedmap/ordered_map_test.go
Outdated
Show resolved
Hide resolved
Yeah the single-machine accounts CI benchmarks (from oasis-sdk CI) goes from ~35 to ~150, and the new bottleneck is serially fetching accounts from storage via host (oasisprotocol/oasis-sdk#278). Also hitting the dispatchers |
ptrus
force-pushed
the
ptrus/feature/checktx-queue
branch
3 times, most recently
from
09251fa to
cbaa6ef
Compare
ptrus
force-pushed
the
ptrus/feature/checktx-queue
branch
from
cbaa6ef to
af41f8d
Compare
kostko
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2548
TODO: