Construction API work

[pro-wh]

based on #22

• phase 1: signing
• phase 2: workflow tests
• phase 3: transaction modeling
• phase 4: payloads and parsing tests

closes #22 because it includes that

[kostko]

Can we also add tests that actually submit transactions to the network and wait for them to be included in a block? Just to make sure that all the transaction hashes are correctly computed.

Also, are there any tests for the construction API provided by the upstream package?

[pro-wh]

Can we also add tests that actually submit transactions to the network and wait for them to be included in a block? Just to make sure that all the transaction hashes are correctly computed.

I'll have to see about how to do that.

Also, are there any tests for the construction API provided by the upstream package?

no ):, unless it's undocumented. although I might as well ask on their forum

[pro-wh]

https://community.rosetta-api.org/t/automated-construction-api-testing/120 oh hey, just one day ago

[kostko]

https://community.rosetta-api.org/t/automated-construction-api-testing/120 oh hey, just one day ago

Cool, we should run that as part of our CI flow :-)

[kostko]

Just note that currently the construction API is using SubmitTx slightly incorrectly (see #24) as it blocks until the transaction gets executed. It may still be fine for tests though. Fixing this requires using Oasis Core master which adds a non-blocking version.

[pro-wh]

There are some major backwards incompatibilities in rosetta-cli 0.4.0. I'll file a separate issue to upgrade to that

#25

[abukosek]

Looks great! Just needs support for the automated construction API testing as part of the test script and it will be good to merge :)