run rosetta-cli check:construction in CI #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
approved these changes
Aug 7, 2020
kostko
reviewed
Aug 7, 2020
| # We'll cause a sigpipe on this process, so ignore the exit status. | ||
| # The downstream awk will exit with nonzero status if this test actually fails without confirming any transactions. | ||
| ./rosetta-cli --configuration-file rosetta-cli-config.json check:construction || true | ||
| } | awk '{ print $0 }; $1 == "[STATS]" && $4 > 0 { confirmed = 1; exit }; END { exit !confirmed }' |
There was a problem hiding this comment.
Maybe we could wait for some more transactions to be confirmed instead of just one ($4 > 0)?
There was a problem hiding this comment.
to answer a question of how, then yes that's how we could do that.
currently we're using this test for a few things: (1) that the transaction hash is correct, (2) that a submitted transaction can go all the way and back to the gateway, and (3) that our modeling in operation sequences is correct. these are all tested in the first round trip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
works around the way it runs forever
fixes #28