Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/client: Make sure Query works with RoundLatest #4217

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Aug 25, 2021

No description provided.

@kostko kostko requested a review from ptrus August 25, 2021 13:04
@kostko kostko force-pushed the kostko/fix/rt-cli-latestround branch from 57619e0 to 4ac9cae Compare August 25, 2021 13:05
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #4217 (4ac9cae) into master (5469a34) will decrease coverage by 0.50%.
The diff coverage is 86.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4217      +/-   ##
==========================================
- Coverage   69.13%   68.63%   -0.51%     
==========================================
  Files         411      411              
  Lines       47507    47514       +7     
==========================================
- Hits        32846    32612     -234     
- Misses      10601    10852     +251     
+ Partials     4060     4050      -10     
Impacted Files Coverage Δ
go/runtime/history/history.go 69.10% <76.47%> (+1.89%) ⬆️
go/consensus/tendermint/roothash/roothash.go 69.12% <100.00%> (ø)
go/runtime/client/client.go 67.11% <100.00%> (-0.36%) ⬇️
go/runtime/client/tests/tester.go 100.00% <100.00%> (ø)
...nsensus/tendermint/apps/keymanager/transactions.go 0.00% <0.00%> (-52.95%) ⬇️
go/ias/http/http.go 20.33% <0.00%> (-44.07%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/runtime/host/sandbox/sandbox.go 71.06% <0.00%> (-11.36%) ⬇️
go/common/sgx/aesm/aesm.go 63.63% <0.00%> (-8.19%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5469a34...4ac9cae. Read the comment docs.

@kostko kostko enabled auto-merge August 25, 2021 14:07
Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deveopers, be aware that passing RoundInvalid now no longer errors out, if anyone was depending on that (:grimacing:)

@kostko kostko merged commit 6a9b020 into master Aug 25, 2021
@kostko kostko deleted the kostko/fix/rt-cli-latestround branch August 25, 2021 17:53
@pro-wh
Copy link
Contributor

pro-wh commented Aug 25, 2021

oh, overlooked this:

this is a breaking change for the API. although I guess the versioning rather tracks chain semantics instead. probably want to have a non-empty changelog for this though @kostko

@kostko
Copy link
Member Author

kostko commented Aug 25, 2021

this is a breaking change for the API

So it doesn't change any API exposed to clients (as those already handled RoundLatest correctly), but it does indeed change the history API which is used internally. But yeah someone could be using this API in their own thing as well, so maybe it should be breaking? Or should it be internal?

And this will be in 21.3 anyway, so a major version bump.

probably want to have a non-empty changelog for this though

The changelog is empty because this fixes a bug introduced in #4210 (which will be part of the same release). But yeah maybe for the history API change?

kostko added a commit that referenced this pull request Aug 25, 2021
@kostko
Copy link
Member Author

kostko commented Aug 25, 2021

Added a changelog entry in #4218.

kostko added a commit that referenced this pull request Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants