Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime: fix round in runtime query #4210

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Aug 23, 2021

Fixes: #4206

TODO:

  • test for GetAnnotatedBlock
  • test for querying past rounds

@kostko kostko linked an issue Aug 23, 2021 that may be closed by this pull request
@ptrus ptrus force-pushed the ptrus/fix/runtime-query-round branch 2 times, most recently from 7cbc35a to 49d712a Compare August 25, 2021 07:06
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #4210 (49d712a) into master (9ac02d7) will decrease coverage by 0.57%.
The diff coverage is 70.58%.

❗ Current head 49d712a differs from pull request most recent head 0c98451. Consider uploading reports for the commit 0c98451 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4210      +/-   ##
==========================================
- Coverage   69.28%   68.70%   -0.58%     
==========================================
  Files         411      411              
  Lines       47455    47472      +17     
==========================================
- Hits        32878    32616     -262     
- Misses      10540    10824     +284     
+ Partials     4037     4032       -5     
Impacted Files Coverage Δ
go/runtime/history/history.go 67.21% <33.33%> (-1.76%) ⬇️
go/runtime/client/client.go 67.29% <53.84%> (-0.55%) ⬇️
go/runtime/client/tests/tester.go 100.00% <100.00%> (ø)
go/runtime/host/mock/mock.go 89.69% <100.00%> (ø)
...nsensus/tendermint/apps/keymanager/transactions.go 0.00% <0.00%> (-52.95%) ⬇️
go/ias/http/http.go 20.33% <0.00%> (-44.07%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/runtime/host/sandbox/sandbox.go 71.06% <0.00%> (-9.90%) ⬇️
go/oasis-node/cmd/ias/auth.go 68.96% <0.00%> (-6.90%) ⬇️
...consensus/tendermint/apps/keymanager/keymanager.go 59.34% <0.00%> (-6.60%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ac02d7...0c98451. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/fix/runtime-query-round branch from 49d712a to b1b4ba1 Compare August 25, 2021 08:01
@ptrus ptrus force-pushed the ptrus/fix/runtime-query-round branch from b1b4ba1 to 0c98451 Compare August 25, 2021 08:03
@ptrus ptrus marked this pull request as ready for review August 25, 2021 08:17
@ptrus ptrus enabled auto-merge August 25, 2021 08:47
@ptrus ptrus merged commit 4443ffd into master Aug 25, 2021
@ptrus ptrus deleted the ptrus/fix/runtime-query-round branch August 25, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passed round ignored in runtime Query
2 participants