Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/registration: Fix RequestShutdown for nodes with no registration #3721

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

jberci
Copy link
Contributor

@jberci jberci commented Feb 22, 2021

In cases where the registration worker was started with a dummy
goroutine that just waits for the service to stop, deregistration
requests would hang, because the dummy wasn't watching the
deregistration channel.

Closes #3524

In cases where the registration worker was started with a dummy
goroutine that just waits for the service to stop, deregistration
requests would hang, because the dummy wasn't watching the
deregistration channel.
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #3721 (1ef8d88) into master (94e6981) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3721      +/-   ##
==========================================
+ Coverage   66.66%   66.84%   +0.18%     
==========================================
  Files         400      400              
  Lines       39778    39783       +5     
==========================================
+ Hits        26519    26594      +75     
+ Misses       9474     9419      -55     
+ Partials     3785     3770      -15     
Impacted Files Coverage Δ
go/worker/registration/worker.go 67.77% <100.00%> (-0.08%) ⬇️
go/consensus/tendermint/full/services.go 80.00% <0.00%> (-4.17%) ⬇️
go/runtime/nodes/versioned.go 73.33% <0.00%> (-1.91%) ⬇️
go/common/sgx/aesm/aesm.go 69.15% <0.00%> (ø)
go/runtime/host/sgx/sgx.go 71.42% <0.00%> (ø)
go/worker/compute/executor/committee/node.go 68.55% <0.00%> (+0.11%) ⬆️
...o/consensus/tendermint/apps/beacon/backend_pvss.go 60.00% <0.00%> (+0.43%) ⬆️
...consensus/tendermint/apps/registry/transactions.go 57.20% <0.00%> (+0.44%) ⬆️
...o/consensus/tendermint/apps/scheduler/scheduler.go 72.75% <0.00%> (+0.51%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e6981...1ef8d88. Read the comment docs.

@jberci jberci force-pushed the jberci/fix/shutdown branch from 84ee4e8 to 1ef8d88 Compare February 22, 2021 15:56
@jberci jberci marked this pull request as ready for review February 22, 2021 15:58
@jberci jberci merged commit 2ffa97e into master Feb 22, 2021
@jberci jberci deleted the jberci/fix/shutdown branch February 22, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controlled shutdown never shuts down a node that didn't register
2 participants