Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT/20.11.x] Storage checkpoint fixes #3411

Merged

Conversation

kostko
Copy link
Member

@kostko kostko commented Oct 15, 2020

jberci and others added 5 commits October 15, 2020 11:48
The timeout in particular is necessary to stop the tests from hanging,
as the grpc client would otherwise try to reconnect ad infinitum.
Make sure to abort the multipart insert after a failed finalize operation as
otherwise all normal batch operations will continue to fail.
@kostko kostko added the c:backport Category: backport to stable branch label Oct 15, 2020
@kostko kostko requested review from ptrus and jberci October 15, 2020 09:54
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #3411 into stable/20.11.x will decrease coverage by 0.01%.
The diff coverage is 70.78%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           stable/20.11.x    #3411      +/-   ##
==================================================
- Coverage           65.53%   65.52%   -0.02%     
==================================================
  Files                 370      370              
  Lines               33091    33223     +132     
==================================================
+ Hits                21686    21768      +82     
- Misses               8214     8258      +44     
- Partials             3191     3197       +6     
Impacted Files Coverage Δ
go/consensus/tendermint/abci/mux.go 50.46% <ø> (-2.26%) ⬇️
go/storage/mkvs/cache.go 78.40% <0.00%> (-0.75%) ⬇️
go/storage/mkvs/checkpoint/checkpoint.go 91.66% <ø> (ø)
go/storage/mkvs/checkpoint/chunk.go 62.36% <33.33%> (-1.38%) ⬇️
go/storage/mkvs/db/api/api.go 54.16% <33.33%> (-4.93%) ⬇️
go/storage/mkvs/checkpoint/restorer.go 91.48% <50.00%> (-0.52%) ⬇️
go/worker/storage/committee/checkpoint_sync.go 78.96% <56.75%> (-0.51%) ⬇️
go/storage/mkvs/commit.go 74.56% <60.00%> (-1.12%) ⬇️
go/storage/mkvs/db/badger/badger.go 68.27% <68.51%> (+0.81%) ⬆️
go/worker/storage/committee/node.go 73.61% <80.00%> (+0.17%) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e45f0...bc64da8. Read the comment docs.

@kostko kostko merged commit 9bb3342 into stable/20.11.x Oct 15, 2020
@kostko kostko deleted the kostko/stable/20.11.x/backport-storage-checkpoint-fixes branch October 15, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:backport Category: backport to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants