Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage checkpoint restore related fixes #3331

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Sep 28, 2020

Fixes #3329
Fixes #3330

  • go/worker/storage: Abort multipart insert after failed finalize

    Make sure to abort the multipart insert after a failed finalize operation as
    otherwise all normal batch operations will continue to fail.

  • go/storage/mkvs: Fix Finalize after checkpoint restore

Make sure to abort the multipart insert after a failed finalize operation as
otherwise all normal batch operations will continue to fail.
@kostko kostko force-pushed the kostko/fix/storage-mkvs-restore-finalize branch from 4b32721 to 21b7131 Compare September 28, 2020 08:52
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #3331 into master will decrease coverage by 0.09%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3331      +/-   ##
==========================================
- Coverage   65.18%   65.08%   -0.10%     
==========================================
  Files         371      371              
  Lines       33177    33181       +4     
==========================================
- Hits        21626    21597      -29     
- Misses       8350     8375      +25     
- Partials     3201     3209       +8     
Impacted Files Coverage Δ
go/worker/storage/committee/checkpoint_sync.go 78.59% <0.00%> (-0.81%) ⬇️
go/storage/mkvs/db/badger/badger.go 68.27% <100.00%> (ø)
go/storage/mkvs/lookup.go 72.63% <0.00%> (-6.32%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 70.00% <0.00%> (-5.00%) ⬇️
go/storage/metrics.go 75.38% <0.00%> (-4.62%) ⬇️
go/consensus/tendermint/full/services.go 81.35% <0.00%> (-4.24%) ⬇️
go/worker/keymanager/handler.go 57.14% <0.00%> (-4.09%) ⬇️
.../consensus/tendermint/apps/roothash/state/state.go 74.28% <0.00%> (-2.86%) ⬇️
go/consensus/tendermint/roothash/roothash.go 69.53% <0.00%> (-2.47%) ⬇️
go/storage/mkvs/insert.go 90.41% <0.00%> (-1.37%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 283763c...21b7131. Read the comment docs.

@kostko kostko merged commit 8c6a5d4 into master Sep 28, 2020
@kostko kostko deleted the kostko/fix/storage-mkvs-restore-finalize branch September 28, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix finalize after checkpoint restore Abort multipart insert after failed finalize
3 participants